Performance fix by caching run methods#49
Merged
Conversation
ThatRendle
added a commit
that referenced
this pull request
Jan 30, 2013
Performance fix by caching run methods
Owner
|
Best. Pull request. Ever. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've run performance tests using WeigHTTP against a simple REST endpoint, like this one:
I noticed that on my machine I could only get a throughput of around 600 req/sec using IIS 8.0, and the follwing WeigHTTP parameters:
weighttp -n 10000 -c 10 -t 4 -k -H "Accept: application/json" http://localhost/objects/1Compare this to MVC4 doing around 4500 req/sec and Web API around 5500 req/sec.
Using ANTS Profiler I've pinpointed the problem being that the handler run methods are compiled at each requests. Much of this was because the HandlerInfo variables were unique per request.
So, I've made a change so that HandlerInfo is a parameter to the lambda allowing the lambda to be cached under the handler type and HTTP method.
This has increased the throughput to around 4500 req/sec.