New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort default files before loading them #57

Merged
merged 1 commit into from May 5, 2017

Conversation

Projects
None yet
2 participants
@kydorn
Copy link
Contributor

kydorn commented May 5, 2017

If we want to load files using the defaults.d feature, we will probably want them to be sorted alphabetically, so we can guarantee the order of the merge.

@kydorn

This comment has been minimized.

Copy link
Contributor

kydorn commented May 5, 2017

Before:

Template sources loaded [FileTemplateSource]
Data sources loaded [DefaultsDataSource]
#DefaultsDataSource:0x00000001836480 : Using values from v2 format common.yaml
Loading defaults from /etc/tiller/defaults.d/01.yaml
Loading defaults from /etc/tiller/defaults.d/04.yaml
Loading defaults from /etc/tiller/defaults.d/02.yaml
Loading defaults from /etc/tiller/defaults.d/03.yaml

After:

Template sources loaded [FileTemplateSource]
Data sources loaded [DefaultsDataSource]
#DefaultsDataSource:0x0000000191a248 : Using values from v2 format common.yaml
Loading defaults from /etc/tiller/defaults.d/01.yaml
Loading defaults from /etc/tiller/defaults.d/02.yaml
Loading defaults from /etc/tiller/defaults.d/03.yaml
Loading defaults from /etc/tiller/defaults.d/04.yaml

@markround markround merged commit e7e5b53 into markround:develop May 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@markround

This comment has been minimized.

Copy link
Owner

markround commented May 5, 2017

Good call! Thanks for the patch :)

@kydorn kydorn deleted the kydorn:sort-defaults branch May 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment