Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Jan 5, 2011
  1. Version bump in lib/CGI.pm

    authored
Commits on Jan 2, 2011
  1. This commit fixes a bug earlier in this development cycle,

    authored
      That commit was "196ab302c0db40647a438b01f0e8027ab8efc21d"
    
      The commit removed "use CGI" from CGI::Cookie, to decouple
      the modules. However, it turns out that bake() requires
      CGI.pm, but there were no tests for that. This patch
      "requires" CGI.pm on demand when bake() is called.
    
      A reality-check test for bake() was also added, which insures
      that CGI.pm is loaded when it is called.
  2. Clean-up code style of return value

    authored
        The meaning is the same. The code style is taken from CGI::Simple::Cookie.
  3. Fix bug with whitespace trimming of cookie elements

    authored
        The whitespace behavior is now identical to CGI::Simple::Cookie, and
        has an automated test.
  4. minor grammar clean-ups.

    authored
  5. Reverse the previous change to the return value for parse(),

    authored
        and test and document the prior behavior when the return value
        is missing. The new short-circuit logic is cleaner but equivalent,
        and avoids emitting an "unitialized string" warning.
    
        Thanks to Yanick for suggesting this direction.
  6. If parse() is given no input, bail out early.

    authored
        This behavior mimics CGI::Simple, and catches potential garbage-in/
        garbage-out program.
  7. Refactor: use formatting from CGI::Simple

    authored
    The goal is to reduce the "diff" of code between CGI.pm and
    CGI::Simple, so some non-meaningful code-style differences
    are being eliminated.
    
    This makes it easier to confirm when the two modules are actually
    different.
Commits on Dec 27, 2010
  1. Adopt the code for raw_fetch from CGI::Simple::Cookie

    authored
    It is simpler, easier to read, but does the same thing.
    I think the test suite has sufficient coverage to show that
    this introduces no regressions.
  2. Add new passing cookie test for names without values

    authored
    These are supported in the spec.
    The same test is being added to the CGI::Simple test suite as well.
    The sample cookie value comes from the Mojo test suite
    (which also supports value-less names).
Commits on Dec 26, 2010
  1. clean up $VERSION declaration

    authored
  2. Quit loading CGI.pm if you just want to use CGI::Cookie

    authored
    - All tests in t/cookie.t pass with the change
    - CGI::Simple::Cookie doesn't need to use CGI::Simple
  3. Refactor: re-use more code from CGI::Simple::Cookie->new()

    authored
    Oddly, we were repeating a lot of the logic of value() in our previous version of the code.
  4. BugFix: CGI::Cookie->new() now follows the documentation and returns …

    authored
    …undef
    
    if the -name and -value args aren't provided.
    
    This new behavior is also consistent with the docs and code of CGI::Simple::Cookie.
  5. minor grammar clean-up

    authored
  6. Port over arg-unpacking clean-up from CGI::Simple::Cookie

    authored
    Several two-line 'shift' unpacks were simplified to one-line.
  7. Refactor: port cleaned-up as_string implementation from CGI::Simple::…

    authored
    …Cookie
    
    From a careful review, the implementations are identical
    
    One small change relates to this ugly line which was cleaned up:
    
      my($cookie) = join("=",(defined $key ? $key : ''),join("&",map escape(defined $_ ? $_ : ''),$self->value));
    
    We were doing a couple of ugly checks for definedness to satisfy "use
    warnings", which CGI::Simple never enabled. Now I just set "no warnings"
    for this block.
    
    Now it's a lot nicer:
    
        my $value = join "&", map { escape($_) } $self->value;
        my @cookie = ( "$name=$value" );
  8. Backport HttpOnly tests from CGI::Simple

    authored
    Our implementation was already compatible.
  9. version bump for CGI::Cookie

    authored
  10. Best Practice: s/new CGI::Cookie/CGI::Cookie->new/

    authored
    Avoids the spread of indirect object notation.
Commits on Dec 24, 2010
  1. Merge remote branch 'yanick/rt-57224'

    authored
        Includes resolving conflict in t/carp.t
  2. Merge branch 'rt-62762-tmpdir'

    authored
        Includes resolving conflict in Changes.
  3. Merge branch 'docs'

    authored
Something went wrong with that request. Please try again.