Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jump to annotation? #5

Closed
titaniumbones opened this issue Nov 11, 2015 · 4 comments
Closed

jump to annotation? #5

titaniumbones opened this issue Nov 11, 2015 · 4 comments

Comments

@titaniumbones
Copy link
Contributor

politza suggests in politza/pdf-tools#134 that it should be possible to link not only to a page but directly to the location of an annotation. How would you suggest I go about adding support for this to the pdfview link syntax? If I can figure it out would you be amenable to such an addition?

Thanks!

@markus1189
Copy link
Owner

Sounds good to me ;)

I guess it would be best to add another link type as done for pdfview https://github.com/markus1189/org-pdfview/blob/master/org-pdfview.el#L39.

Then you can just define the two functions that open and export the links to the annotation. Depending on the fact whether you can also store links to annotations, you also have to add it as shown in https://github.com/markus1189/org-pdfview/blob/master/org-pdfview.el#L40.

Let me know how it goes.

Best,
Markus

@titaniumbones
Copy link
Contributor Author

I guess it would be best to add another link type as done for pdfview https://github.com/markus1189/org-pdfview/blob/master/org-pdfview.el#L39.

could one instead add another delimiter after the page, to the pdfview type? pdfview:/path/to/pdf::page++co-ordinate?

@markus1189
Copy link
Owner

If that works without ambiguities it's fine for me, too. Of course old links should still work so the default behavior when the coordinate is missing should work as previously.

@titaniumbones
Copy link
Contributor Author

see pull request #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants