Menu- and icon-specific button configurations #2

Closed
wants to merge 8 commits into
from

Conversation

Projects
None yet
2 participants
@jgehring
Contributor

jgehring commented Jul 23, 2011

Hi Markus,

As already discussed, here's an implementation for defining mouse button actions for individual menus and icons.

Regards,
Jonas

jgehring added some commits Jul 21, 2011

Added Settings::resolveButtonCode()
This centralizes the duplicate mouse button parsing code in
Settings::load() and Settings:readMenu().
Added explicit context in Settings::readMenu()
This ensures that button configurations in menus will be assigned to the
correct menu or menu item.
Store current menu name in Menu rather than in PieMenuWindow
The previous method missed menu changes (a menu item opens
another menu).
Improved documentation for button configurations in menus
The description is more verbose now, and two examples have been added.
@markusfisch

This comment has been minimized.

Show comment
Hide comment
@markusfisch

markusfisch Jul 24, 2011

Owner

Merged manually with a few little changes.

Thanks for contributing!

Owner

markusfisch commented Jul 24, 2011

Merged manually with a few little changes.

Thanks for contributing!

@markusfisch

This comment has been minimized.

Show comment
Hide comment
@markusfisch

markusfisch Jul 24, 2011

Owner

Hi Jonas,

your changes are merged! New version number is 1.4.0.

Thanks a lot for contributing!

Did a little clean up before the merge. Updating version number, minor
style/order changes, things I hope you don't mind. Except for that context
flag being a string in Settings::readMenu. Got to change :)

Also I hope, you're okay with being mentioned in AUTHORS and PieDock -h.
If not, please tell me so.

Regards,
Markus

PS:
Publishing 1.4.0 as instant version will have to wait until wednesday
unfortunately. Just for your info.

On Sat, 23 Jul 2011 19:11:32 +0200, jgehring
reply@reply.github.com
wrote:

Hi Markus,

As already discussed, here's an implementation for defining mouse button
actions for individual menus and icons.

Regards,
Jonas

O ,-
° o . -´ ' ,-
° .´ . ´,´ ( ° )) . (-;_ . -´ ..
`._' ´

Markus Fisch
http://markusfisch.de

Owner

markusfisch commented Jul 24, 2011

Hi Jonas,

your changes are merged! New version number is 1.4.0.

Thanks a lot for contributing!

Did a little clean up before the merge. Updating version number, minor
style/order changes, things I hope you don't mind. Except for that context
flag being a string in Settings::readMenu. Got to change :)

Also I hope, you're okay with being mentioned in AUTHORS and PieDock -h.
If not, please tell me so.

Regards,
Markus

PS:
Publishing 1.4.0 as instant version will have to wait until wednesday
unfortunately. Just for your info.

On Sat, 23 Jul 2011 19:11:32 +0200, jgehring
reply@reply.github.com
wrote:

Hi Markus,

As already discussed, here's an implementation for defining mouse button
actions for individual menus and icons.

Regards,
Jonas

O ,-
° o . -´ ' ,-
° .´ . ´,´ ( ° )) . (-;_ . -´ ..
`._' ´

Markus Fisch
http://markusfisch.de

@jgehring

This comment has been minimized.

Show comment
Hide comment
@jgehring

jgehring Jul 26, 2011

Contributor

Hi Markus,

Thanks for merging! I'm fine with being mentioned in the AUTHORS file, of course :)

You're right about the context flag. On a first attempt, I used it to store the last token inside the parsing loop, and didn't think about using an enumeration later.

Regards,
Jonas

Contributor

jgehring commented Jul 26, 2011

Hi Markus,

Thanks for merging! I'm fine with being mentioned in the AUTHORS file, of course :)

You're right about the context flag. On a first attempt, I used it to store the last token inside the parsing loop, and didn't think about using an enumeration later.

Regards,
Jonas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment