Skip to content

Menu- and icon-specific button configurations#2

Closed
jgehring wants to merge 8 commits intomarkusfisch:masterfrom
jgehring:button_config
Closed

Menu- and icon-specific button configurations#2
jgehring wants to merge 8 commits intomarkusfisch:masterfrom
jgehring:button_config

Conversation

@jgehring
Copy link
Contributor

Hi Markus,

As already discussed, here's an implementation for defining mouse button actions for individual menus and icons.

Regards,
Jonas

jgehring added 8 commits July 21, 2011 23:52
This centralizes the duplicate mouse button parsing code in
Settings::load() and Settings:readMenu().
This ensures that button configurations in menus will be assigned to the
correct menu or menu item.
The previous method missed menu changes (a menu item opens
another menu).
The description is more verbose now, and two examples have been added.
@markusfisch
Copy link
Owner

Merged manually with a few little changes.

Thanks for contributing!

@markusfisch
Copy link
Owner

Hi Jonas,

your changes are merged! New version number is 1.4.0.

Thanks a lot for contributing!

Did a little clean up before the merge. Updating version number, minor
style/order changes, things I hope you don't mind. Except for that context
flag being a string in Settings::readMenu. Got to change :)

Also I hope, you're okay with being mentioned in AUTHORS and PieDock -h.
If not, please tell me so.

Regards,
Markus

PS:
Publishing 1.4.0 as instant version will have to wait until wednesday
unfortunately. Just for your info.

On Sat, 23 Jul 2011 19:11:32 +0200, jgehring
reply@reply.github.com
wrote:

Hi Markus,

As already discussed, here's an implementation for defining mouse button
actions for individual menus and icons.

Regards,
Jonas

O ,-
° o . -´ ' ,-
° .´ . ´,´ ( ° )) . ( -;_ . -´ ..
`._' ´

Markus Fisch
http://markusfisch.de

@jgehring
Copy link
Contributor Author

Hi Markus,

Thanks for merging! I'm fine with being mentioned in the AUTHORS file, of course :)

You're right about the context flag. On a first attempt, I used it to store the last token inside the parsing loop, and didn't think about using an enumeration later.

Regards,
Jonas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants