Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.7 support #18

Merged
merged 5 commits into from Sep 4, 2018

Conversation

@afiorillo
Copy link
Contributor

commented Sep 3, 2018

Python 3.7 enabled PEP 479 which requires rewriting generator functions to not use StopIteration. I tested this fork with Python 2.7, 3.6, and 3.7.

Also Google Translate returned subtly different translations ("Das" is "That" rather than "This") so I updated the tests to match.

afiorillo added 4 commits Sep 3, 2018
…o their docs) and fixed Python 3.7 testing
@afiorillo afiorillo force-pushed the afiorillo:dev branch 3 times, most recently from fb1f011 to a658ccb Sep 3, 2018
…n 3.4 Travis image, mentioned [here](tox-dev/tox-travis#76).
@afiorillo afiorillo force-pushed the afiorillo:dev branch from a658ccb to 63ea9a0 Sep 3, 2018
@markuskiller markuskiller merged commit 4e71b86 into markuskiller:dev Sep 4, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@markuskiller

This comment has been minimized.

Copy link
Owner

commented Sep 4, 2018

@andrewmfiorillo: Thank you so much for this pull request. I'll gladly merge the changes into dev and hope to be able to get out a new release within the next couple of weeks.

For now, use:


$ pip install -U git+https://github.com/markuskiller/textblob-de.git@dev
$ python -m textblob.download_corpora

Tested with Python3.7 64-bit on Linux (does not seem to work on Windows with my version of git --> SSLCert Error)

@afiorillo

This comment has been minimized.

Copy link
Contributor Author

commented Sep 5, 2018

Great news. Thanks!

Also, I've hit that same issue before with Git on Windows. You may want to check your GIT_SSH variable is properly configured.

@markuskiller

This comment has been minimized.

Copy link
Owner

commented Jan 3, 2019

@andrewmfiorillo: I finally got round to publish the new release with your Python3.7 support. Sorry for the long wait & thanks again for your PR. Now you should be able to pip install from PyPi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.