Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should be able to specify file pattern in build_install_test() #54

Closed
pbreheny opened this issue Jun 7, 2020 · 4 comments
Closed

Should be able to specify file pattern in build_install_test() #54

pbreheny opened this issue Jun 7, 2020 · 4 comments

Comments

@pbreheny
Copy link

@pbreheny pbreheny commented Jun 7, 2020

In run_test_dir(), there is an option, pattern, to specify which file patterns contain testing scripts. However, this option is not present in build_install_test().

@markvanderloo
Copy link
Owner

@markvanderloo markvanderloo commented Jun 7, 2020

Thanks for reporting Patrick, I fixed it in the development version.

I'd be grateful if you could take it for a spin and report if it works for your use case.

@pbreheny
Copy link
Author

@pbreheny pbreheny commented Jun 8, 2020

Works great -- thanks for the quick fix, and for the excellent package!

@pbreheny pbreheny closed this as completed Jun 8, 2020
@pbreheny
Copy link
Author

@pbreheny pbreheny commented Jun 8, 2020

Actually, having worked with this a bit further, there's an issue with regular expressions, in the sense that in your implementation, they go through an additional round (rounds?) of parsing. For example,

build_install_test(testdir='tests', pattern='.*\\.R')

fails:

Error: '\.' is an unrecognized escape in character string starting "'.*\."

Not the end of the world, but could lead to confusion on the part of users, since that same pattern does work in run_test_dir().

I'll reopen and let you decide whether you want to work on this further or not.

@pbreheny pbreheny reopened this Jun 8, 2020
markvanderloo added a commit that referenced this issue Jun 9, 2020
@markvanderloo
Copy link
Owner

@markvanderloo markvanderloo commented Jun 9, 2020

Thanks, I missed that. Just fixed it in ebfa80d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants