Skip to content

Commit

Permalink
qvm-usb: remove scary warning about PV USB stability
Browse files Browse the repository at this point in the history
USBIP (used for PV USB here) is considered stable by Linux maintainers,
so follow their judgement.

Fixes QubesOS/qubes-issues#531
  • Loading branch information
marmarek committed Jun 2, 2016
1 parent e87da9e commit a534b1d
Showing 1 changed file with 0 additions and 20 deletions.
20 changes: 0 additions & 20 deletions qvm-tools/qvm-usb
Expand Up @@ -27,8 +27,6 @@ from optparse import OptionParser
import sys
import os

pvusb_enable_flagfile = '/var/lib/qubes/pvusb-enable.flag'

def main():
usage = "usage: %prog -l [options]\n"\
"usage: %prog -a [options] <vm-name> <device-vm-name>:<device>\n"\
Expand All @@ -49,24 +47,6 @@ def main():

(options, args) = parser.parse_args ()

if not os.path.exists(pvusb_enable_flagfile):
print >> sys.stderr, ""
print >> sys.stderr, "******* WARNING *** WARNING *** WARNING *** WARNING *******"
print >> sys.stderr, "*** ***"
print >> sys.stderr, "*** PVUSB passthrough kernel support is still unstable. ***"
print >> sys.stderr, "*** It can CRASH your VMs. ***"
print >> sys.stderr, "*** ***"
print >> sys.stderr, "***********************************************************"
print >> sys.stderr, ""
print >> sys.stderr, "To use it, you need install kernel from \"unstable\" repository"
print >> sys.stderr, "If you still want to enable it, type capital YES"
print >> sys.stderr, ""
prompt = raw_input ("Do you want enable PV USB support? ")
if prompt == "YES":
open(pvusb_enable_flagfile, "w").close()
else:
exit(1)

if hasattr(os, "geteuid") and os.geteuid() == 0:
if not options.force_root:
print >> sys.stderr, "*** Running this tool as root is strongly discouraged, this will lead you in permissions problems."
Expand Down

0 comments on commit a534b1d

Please sign in to comment.