Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directly require codemirror so it optimizes into main package #337

Closed
wants to merge 1 commit into from

Conversation

easel
Copy link
Contributor

@easel easel commented Feb 27, 2015

No description provided.

@fzaninotto
Copy link
Member

I don't understand, CodeMirror already ends up into ngadmin.min.js, what's the purpose of this one?

@easel
Copy link
Contributor Author

easel commented Feb 27, 2015

That's interesting, perhaps there is a discrepancy between our versions of require.js - I have 2.1.15 and ng-admin is using 2.1.14. Typically a double-nested require won't be picked up by requirejs, and it didn't by mine. I noticed this when I loaded my site against the optimized code and most of the code mirror dependencies were flagged by google page speed as candidates for minification. Are you sure all the code mirror "helpers" are being compiled into the ng-admin.min.js?

@jpetitcolas
Copy link
Contributor

Very old issue. I'm closing it. Feel free to re-open it if you still encounter the issue. :)

By the way, we reviewed our compilation processes using Webpack. All required CodeMirror helpers should be compiled into the built file ng-admin.min.js (but not the ng-admin-only.min.js file).

@jpetitcolas jpetitcolas closed this Jun 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants