Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Doc: how to use dev version in real world project? #19

Merged
merged 1 commit into from Sep 7, 2016

Conversation

jpetitcolas
Copy link
Contributor

No description provided.

@@ -130,3 +130,25 @@ Check `sideEffect/saga.js` for a detail of the inputs and outputs
* Add unit tests
* Add `<ReferenceMany>` field
* Add complex field & input types

## Contributing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about putting that in a CONTRIBUTING.md file? Github / Gitlab have special integration features for this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep that in the README for now, Contributing.md is more a guideline for pull requests. At that step, it's probable that contributors will have already tested their changes (I hope).

@fzaninotto fzaninotto merged commit ad4a690 into master Sep 7, 2016
@fzaninotto
Copy link
Member

Thanks!

@Kmaschta Kmaschta deleted the jpetitcolas-patch-1 branch September 7, 2016 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants