Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR][alpha.4] fix bad import in PaginationActions #3637

Merged
merged 1 commit into from Sep 2, 2019
Merged

[RFR][alpha.4] fix bad import in PaginationActions #3637

merged 1 commit into from Sep 2, 2019

Conversation

natrim
Copy link
Contributor

@natrim natrim commented Sep 2, 2019

should be ra-core

@natrim natrim changed the title [alpha.4] fix bad import in PaginationActions [RFR][alpha.4] fix bad import in PaginationActions Sep 2, 2019
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@djhi djhi added this to the 3.0.0 milestone Sep 2, 2019
@natrim
Copy link
Contributor Author

natrim commented Sep 2, 2019

it's because i am not importing react-admin but ra-core and ra-ui-materialui directly and so my build will fail if something like this happens

@djhi djhi merged commit 737f0d5 into marmelab:next Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants