Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to Create a Pull Request #21

Closed
codytwinton opened this issue Feb 12, 2016 · 5 comments
Closed

Trying to Create a Pull Request #21

codytwinton opened this issue Feb 12, 2016 · 5 comments

Comments

@codytwinton
Copy link
Contributor

@codytwinton codytwinton commented Feb 12, 2016

Trying to create a pull request on your project, but I don't have access. Are you open to pull requests?

@marmelroy

This comment has been minimized.

Copy link
Owner

@marmelroy marmelroy commented Feb 12, 2016

Hi @codywinton. Yup, always open to pull requests. There shouldn't be any access issues...

If you are stuck: https://help.github.com/articles/creating-a-pull-request/

@marmelroy marmelroy closed this Feb 12, 2016
@codytwinton

This comment has been minimized.

Copy link
Contributor Author

@codytwinton codytwinton commented Feb 12, 2016

@marmelroy - Ok, so in order to create a pull request, would I have to clone or fork your repo?

@codytwinton

This comment has been minimized.

Copy link
Contributor Author

@codytwinton codytwinton commented Feb 12, 2016

I cloned your repo, branched off of master, made the changes, and committed my changes to that branch. Now, trying to push that branch to remote and getting this:

Pushing to https://github.com/marmelroy/PhoneNumberKit.git
remote: Permission to marmelroy/PhoneNumberKit.git denied to codywinton.
fatal: unable to access 'https://github.com/marmelroy/PhoneNumberKit.git/': The requested URL returned error: 403
@marmelroy

This comment has been minimized.

Copy link
Owner

@marmelroy marmelroy commented Feb 12, 2016

You can't just push to remote. You need to click the green Compare and Review button and create a pull request via GitHub's system.

Please follow the instructions on https://help.github.com/articles/creating-a-pull-request/

@codytwinton

This comment has been minimized.

Copy link
Contributor Author

@codytwinton codytwinton commented Feb 12, 2016

@marmelroy - My confusion was in Cloning vs. Forking. Solved my issue and created the pull request. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.