Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change PhoneNumberTextField access to open to allow overriding #73

Closed
byrneciaran opened this issue Oct 3, 2016 · 2 comments
Closed

Change PhoneNumberTextField access to open to allow overriding #73

byrneciaran opened this issue Oct 3, 2016 · 2 comments

Comments

@byrneciaran
Copy link

@byrneciaran byrneciaran commented Oct 3, 2016

Good job on the Swift 3.0 release 馃挴

I've come across an issue with the PhoneNumberTextField. I'm overriding this class to draw a custom border and am receiving the compilation error:

Cannot inherit from non-open class 'PhoneNumberTextField' outside of its defining module

Is it possible to change the access level on the PhoneNumberTextField class to "open" from "public" to facilitate overriding it outside of the module ?

@marmelroy

This comment has been minimized.

Copy link
Owner

@marmelroy marmelroy commented Oct 3, 2016

Thanks @byrneciaran. You're right, it should be open. I will do a big access control sweep this evening and will push a fix.

marmelroy added a commit that referenced this issue Oct 3, 2016
@marmelroy

This comment has been minimized.

Copy link
Owner

@marmelroy marmelroy commented Oct 3, 2016

Fix pushed. I'll bundle a new release in a few days.

@marmelroy marmelroy closed this Oct 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.