Bug 621848 - Window loses focus when showing transient windows that do not take focus on map #1

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
1 participant
@vingtetun

Hello,

This bug has been initially created because of the Firefox bug (https://bugzilla.mozilla.org/show_bug.cgi?id=526941) which use the type _NET_WM_WINDOW_TYPE_UTILITY when opening a panel window that does not steal the focus (the noautofocus attribute of the panel is set to "true" in xul).

Reading the code of src/core/window.c and the comment http://git.gnome.org/browse/metacity/tree/src/core/window.c?id=b272c4ca7f3a784d011eea5c3fd348011f8558b3#n2136 it looks like this code path is mostly designed for transient window but actually window of type _NET_WM_WINDOW_TYPE_UTILITY or of type _NET_WM_WINDOW_TYPE_TOOLBAR are also taking this path which seems unappropriated.

The patch just tweak the "if" to ignore them

Do not unfocus the parent window if the newly opened window is of
type META_WINDOW_UTILITY or META_WINDOW_TOOLBAR. Closes #621848.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment