From 828d69491b7f08b0b797eaae2e23169c5f3be9fc Mon Sep 17 00:00:00 2001 From: Yijie Shen Date: Sun, 21 Jun 2015 00:56:46 +0800 Subject: [PATCH] remove unnecessary resolved assertion inside dataType method --- .../sql/catalyst/expressions/complexTypeCreator.scala | 9 --------- 1 file changed, 9 deletions(-) diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala index 8134b71b10504..d44299957d88e 100644 --- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala +++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala @@ -92,7 +92,6 @@ case class CreateNamedStruct(children: Seq[Expression]) extends Expression { private lazy val names = nameExprs.map(_.asInstanceOf[Literal].value.toString) override lazy val dataType: StructType = { - assert(resolved, resolveFailureMessage) val fields = names.zip(valExprs).map { case (name, valExpr) => StructField(name, valExpr.dataType, valExpr.nullable, Metadata.empty) } @@ -125,12 +124,4 @@ case class CreateNamedStruct(children: Seq[Expression]) extends Expression { override def eval(input: InternalRow): Any = { InternalRow(valExprs.map(_.eval(input)): _*) } - - private def resolveFailureMessage(): String = { - if (!childrenResolved) { - s"CreateNamedStruct contains unresolvable children: ${children.filterNot(_.resolved)}." - } else { - checkInputDataTypes().asInstanceOf[TypeCheckFailure].message - } - } }