New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amend to not complete bash completion command #42

Merged
merged 2 commits into from Jun 3, 2016

Conversation

Projects
None yet
2 participants
@lharey
Contributor

lharey commented May 27, 2016

Hi

As per out email re the Pull Request challenge. Unfortunately I have not had much time this month so have only been able to do this small change.

Amended so that it does not complete the 'bash_completion' command

Regards
Lisa

@maros

This comment has been minimized.

Owner

maros commented May 31, 2016

Thank you for your pull request Lisa. However, there seems to be a merge conflict (probably due to the whitespace changes you made). Can you please resolve the conflict so that i can merge this PR.

Merge remote-tracking branch 'upstream/master'
* upstream/master:
  Cleanups
  bash completion: replace dashes in variable names with underscores
  Always create correct documentation for cmd_split, regardless of type constraint
  Rename hints key
  Add comments
  Prepare release notes
  Improved parsing or @argv. MooseX::App::ParsedArgv not retains the order of the elements
  Add tests to check for correct array element order
  Cleanups
  Apply spelling patch #39
  Add ability to negate boolean options #29

Conflicts:
	lib/MooseX/App/Plugin/BashCompletion/Command.pm
@lharey

This comment has been minimized.

Contributor

lharey commented Jun 1, 2016

Hi, I've resolved the conflicts as requested, so hopefully you can merge this now.
Thanks
Lisa

@maros maros merged commit 3ab80a8 into maros:master Jun 3, 2016

@maros

This comment has been minimized.

Owner

maros commented Jun 3, 2016

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment