Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newspapers search form #151

Merged
merged 12 commits into from May 31, 2019
Merged

Newspapers search form #151

merged 12 commits into from May 31, 2019

Conversation

ebenenglish
Copy link
Collaborator

This PR addresses #86, and includes:

  • A newspapers search interface, at /newspapers_search
  • Installer installs BlacklightAdvancedSearch (to facilitate newspaper search features)
  • Updates to indexing, so that place of publication and language metadata values from NewspaperTitle and NewspaperIssue objects are copied to NewspaperPage Solr records
  • Minor style updates to NewspaperTitle show view (search within title)
  • Remove redundant config/locales/hyrax.en.yml (which was a copied wholesale from Hyrax) and replace with config/locales/newspaper_works.en.yml.
  • Remove redundant rake tasks that had been copied from Hyrax
  • Feature specs for testing front-end interaction with newspapers_search, NewspaperTitle search, and view all front pages

TO TEST THIS BRANCH:

  • Remove any existing .internal_test_app and re-run the installer.
  • Create a set of test objects in the console similar to those in spec/features_shared.rb
  • Start the app and go to /newspapers_search to test.

@ghost ghost assigned ebenenglish May 16, 2019
@ghost ghost added the review label May 16, 2019
Copy link
Collaborator

@brianmcbride brianmcbride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newspapers_search form is working as expected. I was able to successfully search newspapers based on date ranges and the first page function is working as expected. Also, the search form adjusts when newspapers with different languages are added to the collection.

All rake tasks passed.

@ebenenglish ebenenglish merged commit 461b916 into master May 31, 2019
@ebenenglish ebenenglish deleted the newspapers-search-form branch May 31, 2019 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants