Transactions should be rolled back on exception #92

Closed
agronholm opened this Issue May 16, 2012 · 2 comments

2 participants

@agronholm

Currently, the transactional middleware does not handle exceptions coming from the application (or from wrapped middleware). That causes transactions to be committed when an exception occurs. The transactional middleware was only designed to react to HTTP status being 4xx or 5xx, but status isn't available when an exception is raised.

@amcgregor
Marrow Open Source Collective member

Pushed in feature/92-rollback and awaiting approval. Still needs a dedicated test for this problem.

@agronholm

Test written and merged in changeset d70ae7d.

@agronholm agronholm closed this Jul 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment