Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve subtask details in logs #2836

Merged
merged 1 commit into from Mar 18, 2022

Conversation

wjsi
Copy link
Member

@wjsi wjsi commented Mar 18, 2022

What do these changes do?

Add subtask details when handling in subtasks and workers. repr(subtask) will look like

<Subtask id=C2Yl0r1tAIAA1RIdwCfA5ANN results=[TensorAdd(e2e822e32d0931a0be7c1646fe873dde_0)]>

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@wjsi wjsi added this to the v0.9.0rc1 milestone Mar 18, 2022
@wjsi wjsi added this to In progress in Misc via automation Mar 18, 2022
@wjsi wjsi force-pushed the enh/subtask_log_detail branch 2 times, most recently from 368a389 to 2053d46 Compare March 18, 2022 09:04
@wjsi wjsi added the to be backported Indicate that the PR need to be backported to stable branch label Mar 18, 2022
Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Misc automation moved this from In progress to Reviewer approved Mar 18, 2022
@qinxuye qinxuye merged commit eafdf2e into mars-project:master Mar 18, 2022
Misc automation moved this from Reviewer approved to Done Mar 18, 2022
@wjsi wjsi deleted the enh/subtask_log_detail branch March 18, 2022 12:05
wjsi added a commit to wjsi/mars that referenced this pull request Mar 20, 2022
qinxuye pushed a commit that referenced this pull request Mar 20, 2022
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Misc
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants