Surefire version, Java 11 error in ConstructionStageTest, #107
Labels
Comments
|
@shirishag75 , can you fill out the issue template in future ? It's good to let everyone know the system on which you run the test. Appreciate that. This seems to be openjdk 11 related.
The |
|
I edited the bug so that system information is shared as well. Another point is that the surefire-report that we are using here is version 2.20.1 while in Debian buster we have the latest 2.22.1 in Debian/buster This is for @seamlik |
|
What version is the Surefire in Debian is irrelevant, as Maven will honor the original POM and download the artifacts online. Debian's artifacts will only be used when building a Debian package that fully complies to The Debian Policy. |
|
True, that was my amateur way of motivating you to see if something can be worked out :) |
True. I have no control over what version of surefire it will use. I do need to point out the fact that I encounter no issue when running maven test in java 10. |
|
ah, then perhaps it is that because I have both the jdk installed - Although Just a note, this is the only test in the entire test-suite which fails, all the others pass at this point in time. |
|
Update - |
mokun
added a commit
that referenced
this issue
Nov 13, 2018
r4543 2018-11-12 Note: this builds addresses the request to comment out a unit test for Java 11 testing in issue #107 ## CHANGE 1. Modify determinedSettlementParkedLocationAndFacing() in GroundVehicle for passing maven test. - the value of "total" cannot be -1 during unit test.
mokun
added a commit
that referenced
this issue
Nov 13, 2018
r4544 2018-11-12 Note: this builds addresses the request to comment out a unit test for Java 11 testing in issue #107 ## CHANGES 1. Comment out the line for loading ConstructionStageTest in JUnitTests.
mokun
changed the title
|
Thank you for the workaround, hopefully some days down the line we would have a real fix. I was able to move a bit forward but got stuck again, another issue, another day :) |
|
Since your are using the headless edition, in your mars-sim's pom.xml, comment out the mars-sim-network, mars-sim-main and mars-sim-ui, before you run maven test. |
|
any update on the java 1 error in ConstructionStageTest, it would be nice if we are able to figure out what's wrong in here and fix it. |
|
In my setup, there's nothing wrong with I just re-enabled it and put it to test. See below : |
mokun
referenced
this issue
Dec 5, 2018
r4642 2018-12-05 ## CHANGE 1. Reactivate ConstructionSiteTest and ConstructionStageTest in JUnitTests. 2. Relocate a static method from AmountResource to ResourceUtil. 3. Relocate a static method from ItemResource to ItemResourceUtil.
|
I just reactivated the two tests. See if you can get them working in your setup. May be you want to try out just one at a time. All you have to do is to comment them out if they don't compile. For instances, you can use
|
|
I am still getting the error, see at https://paste.debian.net/1054577/ |
Can you share the whole path of the Construction directory ? Got it, it seems to be ~/games/mars-sim/mars-sim-core/src/main/java/org/mars_sim/msp/core/structure/construction$ leafpad JUnitTests.java if I'm not wrong. |
|
This is the end result it shows atm - |
No. It's inside the See JUnitTests |
|
I did the changes and compile but no change - I am still getting the same error :( |
mokun
referenced
this issue
Dec 7, 2018
r4647 2018-12-06 ## RELATED 1. #162 2. #163 3. #122 ## CHANGE 1. Update google guice to guice 4.2.2 to the "illegal reflective access operation" by com.google.inject.internal.cglib.core. $ReflectUtils$1 when running maven test. 2. Add slf4j-simple 1.7.25 in order to remove the slf4j error at the start of the sim.
|
With the new google guice 4.2.2 from the last build, I hope it takes care of the reflection access issue. Let me know if you can run maven test successfully. If not, comment out those modules that requires openjfx. See if it has to do with openjfx |
|
I am still running into the whole shebang - and what all comes underneath it. In pom.xml only three modules are activated, mars-sim-core, mars-sim-headless and mars-sim-mapdata. All the rest are not activated. I am stumped :( |
|
Can you post the stack trace on a few lines before and after it encounters |
|
Is this good enough or no ? |
|
It's the method |
|
Can you comment that out in Settlement.java to see if the null issue go away ? Chances are that the NullPointerException has to do with the UnitManager instance being null inside |
|
After doing the above, I was able to build without an issue. Got a success at the end - |
|
The only difference in the output is - So for some days there is just no data. Perhaps this can be fixed. |
|
Can you turn on |
|
Let's close this thread and not mixing in other things here. If encountering any bugs, open a new issue. |
|
I had to remove Settlement.java, git pull again and again do the fixing so was able to package and play the new version. |
mokun
added a commit
that referenced
this issue
Dec 14, 2018
r4671 2018-12-14 ## ISSUE 1. #107 ## CHANGE 1. Comment out the followings in Settlement - updateAllAssociatedPeople() - updateAllAssociatedRobots()
|
I'm reading this on the java 11 migration. |
|
sounds like the right thing to do. Having a single pom with reduce complexity like anything. I was sold in the first para itself. I tried running Seems we would have to update whole lot of modules. Does seem like lot of work. Let me see if it does its cycle and produces some sort of report on what it thinks would be best for our project. Interesting, see https://paste.debian.net/1064231/ . Seems everything works once everything is updated. It does tell us many things. |
We already have the latest version on all plugins. |
mokun
added a commit
that referenced
this issue
Feb 2, 2019
r4862 2019-02-02 Note: this builds enables trouble-free switching between Java compiler version (namely 8, 9, 10, or 11) in the <release> tag in mars-sim's pom.xml as follows : <modelVersion>4.0.0</modelVersion> <groupId>net.sf</groupId> <artifactId>mars-sim</artifactId> <packaging>pom</packaging> <version>3.1.0-b2</version> <name>mars-sim</name> <url>https://github.com/mars-sim/mars-sim</url> <inceptionYear>2009</inceptionYear> <properties> <release>8</release> <project.version>3.1.0-b2</project.version> ## ISSUE 1. #107 2. #74 ## CHANGE 1. Modify PromptComboBoxRenderer to extend DefaultListCellRenderer in a number of TabPanel* class, BuildingPanelFarming and SettlementTransparentPanel 2. Add markdowngenerator in mars-sim-core's pom.xml. 3. Remove xstream in mars-sim-core's pom.xml.
|
This is an old. closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Dear all,
This was mentioned in passing but guess should be shared -
The text was updated successfully, but these errors were encountered: