New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration from Sourceforge #4

Closed
larsnaesbye opened this Issue Jan 19, 2017 · 72 comments

Comments

Projects
None yet
4 participants
@larsnaesbye
Contributor

larsnaesbye commented Jan 19, 2017

  • Re-import entire SVN repo through the importer, mapping contributors to their GH accounts
  • Establish a way of downloading the latest stable release on GH
  • Put up notice on SF that we are moving, and the code is updated on GH from now
  • Move the webpages over to a GH Pages branch (this might change the URL of the page)
  • Copy all information over in GH Wiki
  • Copy open issues and questions over
  • After a while - close the SF repo
@larsnaesbye

This comment has been minimized.

Show comment
Hide comment
@larsnaesbye

larsnaesbye Jan 19, 2017

Contributor

Could we start with moving over issue tracking from SF? Like stopping new issues, closing the ones we can, and then move the rest over?

Contributor

larsnaesbye commented Jan 19, 2017

Could we start with moving over issue tracking from SF? Like stopping new issues, closing the ones we can, and then move the rest over?

@shirishag75

This comment has been minimized.

Show comment
Hide comment
@shirishag75

shirishag75 Jan 21, 2017

umm... there is this script which might help https://github.com/cmungall/gosf2github but it does have some limitations and requirements -

Requirements:

TIP:

Note that the API does not grant permission to create the tickets as
if they were created by the original user, so if your token was
generated from your account, it will look like you submitted the
ticket and comments.

Create an account for an agent like https://github.com/bbopjenkins -
use this account to generate the token. This may be better than having
everything show up under your own personal account

Hope it's useful.

shirishag75 commented Jan 21, 2017

umm... there is this script which might help https://github.com/cmungall/gosf2github but it does have some limitations and requirements -

Requirements:

TIP:

Note that the API does not grant permission to create the tickets as
if they were created by the original user, so if your token was
generated from your account, it will look like you submitted the
ticket and comments.

Create an account for an agent like https://github.com/bbopjenkins -
use this account to generate the token. This may be better than having
everything show up under your own personal account

Hope it's useful.

@larsnaesbye

This comment has been minimized.

Show comment
Hide comment
@larsnaesbye

larsnaesbye Feb 14, 2017

Contributor

What do you say? Should I just copy/paste the SF issues over?

Contributor

larsnaesbye commented Feb 14, 2017

What do you say? Should I just copy/paste the SF issues over?

@shirishag75

This comment has been minimized.

Show comment
Hide comment
@shirishag75

shirishag75 Feb 14, 2017

@larsnaesbye . I just did one at #8 . You will need to put the forwarding address at the sourceforge.net ticket and close it (I don't have admin access there) and put from where it is being imported in the ticket here .

Would have preferred to import the user account but for that to happen, you would have to use the script. Optionally you could use connect with the reporters and ask them to put the report here and just close the bugs there.

shirishag75 commented Feb 14, 2017

@larsnaesbye . I just did one at #8 . You will need to put the forwarding address at the sourceforge.net ticket and close it (I don't have admin access there) and put from where it is being imported in the ticket here .

Would have preferred to import the user account but for that to happen, you would have to use the script. Optionally you could use connect with the reporters and ask them to put the report here and just close the bugs there.

@larsnaesbye

This comment has been minimized.

Show comment
Hide comment
@larsnaesbye

larsnaesbye Feb 14, 2017

Contributor

Cool! I closed it at Sourceforge with a reference. Feel free to copy/paste the others over and I will also close them up :)

Contributor

larsnaesbye commented Feb 14, 2017

Cool! I closed it at Sourceforge with a reference. Feel free to copy/paste the others over and I will also close them up :)

@larsnaesbye

This comment has been minimized.

Show comment
Hide comment
@larsnaesbye

larsnaesbye Feb 14, 2017

Contributor

I'm migrating the rest over myself. Seems easier that way.

Contributor

larsnaesbye commented Feb 14, 2017

I'm migrating the rest over myself. Seems easier that way.

@larsnaesbye

This comment has been minimized.

Show comment
Hide comment
@larsnaesbye

larsnaesbye Feb 14, 2017

Contributor

It is done :-) Now we need to move the code over.....

Contributor

larsnaesbye commented Feb 14, 2017

It is done :-) Now we need to move the code over.....

@shirishag75

This comment has been minimized.

Show comment
Hide comment
@shirishag75

shirishag75 Feb 14, 2017

@larsnaesbye I didn't want to announce after moving over each bug, hence it was good you went that way.

Did you look at the discussion that we had for migrating code over... Git and Github are good with code, not so good with binary images.

shirishag75 commented Feb 14, 2017

@larsnaesbye I didn't want to announce after moving over each bug, hence it was good you went that way.

Did you look at the discussion that we had for migrating code over... Git and Github are good with code, not so good with binary images.

@larsnaesbye

This comment has been minimized.

Show comment
Hide comment
@larsnaesbye

larsnaesbye Feb 14, 2017

Contributor

No I didnt....was is on FaceBook?

Contributor

larsnaesbye commented Feb 14, 2017

No I didnt....was is on FaceBook?

@shirishag75

This comment has been minimized.

Show comment
Hide comment
@shirishag75

shirishag75 Feb 14, 2017

@larsnaesbye nope...actually in my head :( Apparently git is not so good with binary images. See some of the discussions on stackoverflow precisely on this topic -

http://stackoverflow.com/questions/1911005/git-and-binary-data#1911054

http://stackoverflow.com/questions/3618447/using-git-for-images

as well as

http://softwareengineering.stackexchange.com/questions/80962/should-images-be-stored-in-a-git-repository

the consensus of most of the discussions has been have the images remain in svn as a sub-module triggered by git while the code-base is in git.

There are two points to consider -

  • Git is not good with managing diffs between binary images unlike it is with text

  • Each image that you put via git is also copied in the hidden ~/.git directory as well.

Both of the above will swell the image directory quite a bit.

Anyways, you and @mokun need to simplify and keep all images together which I had shared on e-mail as a finding. That actually would be quite a task in itself.

shirishag75 commented Feb 14, 2017

@larsnaesbye nope...actually in my head :( Apparently git is not so good with binary images. See some of the discussions on stackoverflow precisely on this topic -

http://stackoverflow.com/questions/1911005/git-and-binary-data#1911054

http://stackoverflow.com/questions/3618447/using-git-for-images

as well as

http://softwareengineering.stackexchange.com/questions/80962/should-images-be-stored-in-a-git-repository

the consensus of most of the discussions has been have the images remain in svn as a sub-module triggered by git while the code-base is in git.

There are two points to consider -

  • Git is not good with managing diffs between binary images unlike it is with text

  • Each image that you put via git is also copied in the hidden ~/.git directory as well.

Both of the above will swell the image directory quite a bit.

Anyways, you and @mokun need to simplify and keep all images together which I had shared on e-mail as a finding. That actually would be quite a task in itself.

@larsnaesbye

This comment has been minimized.

Show comment
Hide comment
@larsnaesbye

larsnaesbye Feb 14, 2017

Contributor

Hmmm...I don't see the links as making a good case for not moving. Do we really have that many large binary files? I know that we could clean up a lot too...

Contributor

larsnaesbye commented Feb 14, 2017

Hmmm...I don't see the links as making a good case for not moving. Do we really have that many large binary files? I know that we could clean up a lot too...

@larsnaesbye

This comment has been minimized.

Show comment
Hide comment
@larsnaesbye

larsnaesbye Feb 16, 2017

Contributor

I'm thinking about moving the wiki over next...

Contributor

larsnaesbye commented Feb 16, 2017

I'm thinking about moving the wiki over next...

@shirishag75

This comment has been minimized.

Show comment
Hide comment
@shirishag75

shirishag75 Feb 16, 2017

@larsnaesbye Go ahead about the wiki. About binary images ideally, first cleaning up and then having some sort of history and understanding as to how often the changes to the binary files would let us have some idea of the future.

If for instance, binary files are not touched for many a year, then it might make sense to move them over to git, if on the other hand, there are frequent changes to the binary images, either new binary images or texturing, higher resolution pictures etc. then it might make sense to split the repository in two, the code part and the images part with images remaining in the svn module while the rest of the code moves onto git.

Also remember that github has space limitations (even for foss projects) so we can't allow it to grow exponentially, see https://help.github.com/articles/what-is-my-disk-quota/ . Hope it clears some of the confusion.

shirishag75 commented Feb 16, 2017

@larsnaesbye Go ahead about the wiki. About binary images ideally, first cleaning up and then having some sort of history and understanding as to how often the changes to the binary files would let us have some idea of the future.

If for instance, binary files are not touched for many a year, then it might make sense to move them over to git, if on the other hand, there are frequent changes to the binary images, either new binary images or texturing, higher resolution pictures etc. then it might make sense to split the repository in two, the code part and the images part with images remaining in the svn module while the rest of the code moves onto git.

Also remember that github has space limitations (even for foss projects) so we can't allow it to grow exponentially, see https://help.github.com/articles/what-is-my-disk-quota/ . Hope it clears some of the confusion.

@larsnaesbye

This comment has been minimized.

Show comment
Hide comment
@larsnaesbye

larsnaesbye Feb 16, 2017

Contributor

I know, but we've been notoriously bad about including everything ever tried out in the repository. If we are forced to clean up just a tiny bit, then it's only good IMHO.

Contributor

larsnaesbye commented Feb 16, 2017

I know, but we've been notoriously bad about including everything ever tried out in the repository. If we are forced to clean up just a tiny bit, then it's only good IMHO.

@shirishag75

This comment has been minimized.

Show comment
Hide comment
@shirishag75

shirishag75 Feb 16, 2017

true. That is the reason why Git has branches

shirishag75 commented Feb 16, 2017

true. That is the reason why Git has branches

@larsnaesbye larsnaesbye removed this from the 3.10 milestone Feb 19, 2017

@larsnaesbye

This comment has been minimized.

Show comment
Hide comment
@larsnaesbye

larsnaesbye Feb 20, 2017

Contributor

I've now moved most of the wiki over. Some pages I skipped because they contained things we've already done. There are 3 pages that have important images or formatting I'll have to look deeper into:

  • Getting_Started_with_MSP
  • Setting_up_a_MSP_development_environment_with_the_command_line
  • UML_Diagrams

Images might have to be stored in a separate repo, like when we move the webpages over to GitHub Pages. I'll look into this, but please do edit away on what's been ported already :)

Contributor

larsnaesbye commented Feb 20, 2017

I've now moved most of the wiki over. Some pages I skipped because they contained things we've already done. There are 3 pages that have important images or formatting I'll have to look deeper into:

  • Getting_Started_with_MSP
  • Setting_up_a_MSP_development_environment_with_the_command_line
  • UML_Diagrams

Images might have to be stored in a separate repo, like when we move the webpages over to GitHub Pages. I'll look into this, but please do edit away on what's been ported already :)

@mokun

This comment has been minimized.

Show comment
Hide comment
@mokun

mokun Feb 20, 2017

Member
Member

mokun commented Feb 20, 2017

@larsnaesbye

This comment has been minimized.

Show comment
Hide comment
@larsnaesbye

larsnaesbye Feb 20, 2017

Contributor

Yeah, I've wondered too how people manage to have it expanded by default, like here.

Contributor

larsnaesbye commented Feb 20, 2017

Yeah, I've wondered too how people manage to have it expanded by default, like here.

@shirishag75

This comment has been minimized.

Show comment
Hide comment
@shirishag75

shirishag75 Feb 20, 2017

umm... has anybody looked at settings ? Specifically https://github.com/mars-sim/mars-sim/settings . For some reasons, github pages is disabled while the wiki has pages. Could somebody look into that ?

shirishag75 commented Feb 20, 2017

umm... has anybody looked at settings ? Specifically https://github.com/mars-sim/mars-sim/settings . For some reasons, github pages is disabled while the wiki has pages. Could somebody look into that ?

@larsnaesbye

This comment has been minimized.

Show comment
Hide comment
@larsnaesbye

larsnaesbye Feb 20, 2017

Contributor

That's not the same thing, I'm afraid. Github Pages is web pages served through a web server, but the wiki is just another repository of .md files (or whatever we choose).

Contributor

larsnaesbye commented Feb 20, 2017

That's not the same thing, I'm afraid. Github Pages is web pages served through a web server, but the wiki is just another repository of .md files (or whatever we choose).

@larsnaesbye

This comment has been minimized.

Show comment
Hide comment
@larsnaesbye

larsnaesbye Feb 20, 2017

Contributor

An example of GitHub Pages is this: http://larsnaesbye.github.io/tempus/ - from a dead project of mine.

Contributor

larsnaesbye commented Feb 20, 2017

An example of GitHub Pages is this: http://larsnaesbye.github.io/tempus/ - from a dead project of mine.

@shirishag75

This comment has been minimized.

Show comment
Hide comment
@shirishag75

shirishag75 Feb 21, 2017

all is good. I asked the github people and this is what they had to say -

Thanks for writing in! Your Wiki had a custom sidebar titled "misc" which was preventing the automatically generated sidebar from being unfolded onto the page by default. The custom sidebar was empty, so I deleted it for you. Your Wiki's sidebar is now displayed by default.

https://github.com/mars-sim/mars-sim/wiki

shirishag75 commented Feb 21, 2017

all is good. I asked the github people and this is what they had to say -

Thanks for writing in! Your Wiki had a custom sidebar titled "misc" which was preventing the automatically generated sidebar from being unfolded onto the page by default. The custom sidebar was empty, so I deleted it for you. Your Wiki's sidebar is now displayed by default.

https://github.com/mars-sim/mars-sim/wiki

@larsnaesbye

This comment has been minimized.

Show comment
Hide comment
@larsnaesbye

larsnaesbye Feb 21, 2017

Contributor

Yeah! Also know that you can clone wikis and add other files to them. This is how I plan to add images :-)

Contributor

larsnaesbye commented Feb 21, 2017

Yeah! Also know that you can clone wikis and add other files to them. This is how I plan to add images :-)

@mokun

This comment has been minimized.

Show comment
Hide comment
@mokun

mokun Feb 21, 2017

Member

Shirshag,

Thanks for engaging us in getting things rolling and also contacting github to remove the side bar.

Lars,

Thanks for converting those wiki pages.

I can see you add some new pages with "Project Development Idea: Roads", etc, yestersday.

I've processed a few of them--lightly edited the formats, updated the contents, added new comments. etc.

Once done, I'll move the edited page to under "D. New Proposals".

Just so you know.

-Manny

Member

mokun commented Feb 21, 2017

Shirshag,

Thanks for engaging us in getting things rolling and also contacting github to remove the side bar.

Lars,

Thanks for converting those wiki pages.

I can see you add some new pages with "Project Development Idea: Roads", etc, yestersday.

I've processed a few of them--lightly edited the formats, updated the contents, added new comments. etc.

Once done, I'll move the edited page to under "D. New Proposals".

Just so you know.

-Manny

@larsnaesbye

This comment has been minimized.

Show comment
Hide comment
@larsnaesbye

larsnaesbye Mar 4, 2017

Contributor
svn co https://github.com/mars-sim/mars-sim-git
Contributor

larsnaesbye commented Mar 4, 2017

svn co https://github.com/mars-sim/mars-sim-git
@mokun

This comment has been minimized.

Show comment
Hide comment
@mokun
Member

mokun commented Mar 5, 2017

@larsnaesbye

This comment has been minimized.

Show comment
Hide comment
@larsnaesbye

larsnaesbye Mar 5, 2017

Contributor

Checkout the GitHub repo using Subversion :-)

Contributor

larsnaesbye commented Mar 5, 2017

Checkout the GitHub repo using Subversion :-)

@mokun

This comment has been minimized.

Show comment
Hide comment
@mokun

mokun Mar 5, 2017

Member

why and when do we need to do this ?

Member

mokun commented Mar 5, 2017

why and when do we need to do this ?

@larsnaesbye

This comment has been minimized.

Show comment
Hide comment
@larsnaesbye

larsnaesbye Mar 5, 2017

Contributor

My point is that you can setup Eclipse and Subversion to use the GitHub repo. So we no longer need the SF repo for people who prefer Subversion.

Contributor

larsnaesbye commented Mar 5, 2017

My point is that you can setup Eclipse and Subversion to use the GitHub repo. So we no longer need the SF repo for people who prefer Subversion.

@mokun

This comment has been minimized.

Show comment
Hide comment
@mokun

mokun Mar 5, 2017

Member

Can you show me step by step on what to do now ?

I just made a quick code change in eclipse. I made a commit to SF's SVN. Now, what do I do to sync up the changes in GH's git ?

What would you have done differently ?

When will you do "svn co https://github.com/mars-sim/mars-sim-git" ?

Member

mokun commented Mar 5, 2017

Can you show me step by step on what to do now ?

I just made a quick code change in eclipse. I made a commit to SF's SVN. Now, what do I do to sync up the changes in GH's git ?

What would you have done differently ?

When will you do "svn co https://github.com/mars-sim/mars-sim-git" ?

@larsnaesbye

This comment has been minimized.

Show comment
Hide comment
@larsnaesbye

larsnaesbye Mar 5, 2017

Contributor

Hold on. Do we really want two different repos, in two different places, using two different versioning systems, getting out of sync with each other all the time???
My thought was that from the day we had imported to GitHub we used the Github repo. People who wanted to use Subversion could still do that, others could use git.

Contributor

larsnaesbye commented Mar 5, 2017

Hold on. Do we really want two different repos, in two different places, using two different versioning systems, getting out of sync with each other all the time???
My thought was that from the day we had imported to GitHub we used the Github repo. People who wanted to use Subversion could still do that, others could use git.

@larsnaesbye

This comment has been minimized.

Show comment
Hide comment
@larsnaesbye

larsnaesbye Mar 5, 2017

Contributor

Is it because we need an instruction in setting up Eclipse to work with the Github repo?

Contributor

larsnaesbye commented Mar 5, 2017

Is it because we need an instruction in setting up Eclipse to work with the Github repo?

@shirishag75

This comment has been minimized.

Show comment
Hide comment
@shirishag75

shirishag75 Mar 5, 2017

@mokun please answer Lars. It doesn't make sense to have two repos, we want/need a single repo. in git.

Having said that, there are few blog posts I think both of you should be aware of -

https://joeyh.name/blog/entry/what_I_would_ask_my_lawyers_about_the_new_Github_TOS/

https://joeyh.name/blog/entry/removing_everything_from_github/

https://www.earth.li/~noodles/blog/2017/03/github-tos-change.html

https://www.mirbsd.org/permalinks/wlog-10_e20170301-tg.htm#e20170301-tg_wlog-10

Unfortunately, it doesn't tell why github.com did feel the need to change the TOS. That side of the story is unexplored.

The github branchable hack seems like an interesting one -

https://github-backup.branchable.com/README/

shirishag75 commented Mar 5, 2017

@mokun please answer Lars. It doesn't make sense to have two repos, we want/need a single repo. in git.

Having said that, there are few blog posts I think both of you should be aware of -

https://joeyh.name/blog/entry/what_I_would_ask_my_lawyers_about_the_new_Github_TOS/

https://joeyh.name/blog/entry/removing_everything_from_github/

https://www.earth.li/~noodles/blog/2017/03/github-tos-change.html

https://www.mirbsd.org/permalinks/wlog-10_e20170301-tg.htm#e20170301-tg_wlog-10

Unfortunately, it doesn't tell why github.com did feel the need to change the TOS. That side of the story is unexplored.

The github branchable hack seems like an interesting one -

https://github-backup.branchable.com/README/

@mokun

This comment has been minimized.

Show comment
Hide comment
@mokun

mokun Mar 5, 2017

Member

Yes I'll definitely prefer having one repo, instead of two.

It's just that we need to write down the steps on how to set up the developmental environment to do it the new way.

Member

mokun commented Mar 5, 2017

Yes I'll definitely prefer having one repo, instead of two.

It's just that we need to write down the steps on how to set up the developmental environment to do it the new way.

@mokun

This comment has been minimized.

Show comment
Hide comment
@mokun

mokun Mar 5, 2017

Member

@shirishag75 I'll read up on GitHub's new TOS to see what the deal is.

Normally, in a official release, we bundle the source code of mars-sim together with its jar, plus all the jars that we depend on. These jars are downloaded from maven. We call them maven artifacts and they are under various BSD, CC and GPL licenses.

So far, Scott is using GPL 2.0 license to cover the source codes in mars-sim.

I don't understand how the latest changes in GitHub would adversely the open source projects out there yet and if it would somehow affect the distribution of mars-sim.

May be the GitHub's change worsens the inherent legal mumble jumbo that have been there already. To me when it comes to licensing, nothing is clear cut until you meet your opponents in courts. Oracle vs. Google is one example that licensing aren't definitive no matter what. Do let me know any findings you may have.

Member

mokun commented Mar 5, 2017

@shirishag75 I'll read up on GitHub's new TOS to see what the deal is.

Normally, in a official release, we bundle the source code of mars-sim together with its jar, plus all the jars that we depend on. These jars are downloaded from maven. We call them maven artifacts and they are under various BSD, CC and GPL licenses.

So far, Scott is using GPL 2.0 license to cover the source codes in mars-sim.

I don't understand how the latest changes in GitHub would adversely the open source projects out there yet and if it would somehow affect the distribution of mars-sim.

May be the GitHub's change worsens the inherent legal mumble jumbo that have been there already. To me when it comes to licensing, nothing is clear cut until you meet your opponents in courts. Oracle vs. Google is one example that licensing aren't definitive no matter what. Do let me know any findings you may have.

@mokun mokun added this to the 3.10 milestone Mar 5, 2017

@shirishag75

This comment has been minimized.

Show comment
Hide comment
@shirishag75

shirishag75 Mar 5, 2017

@mokun - if you are using eclipse as the IDE on MS-Windows, then this probably will be most instructive to you -

http://www.vogella.com/tutorials/EclipseGit/article.html .

I haven't had to use an IDE for anything, yet... and on GNU/Linux the CLI is pretty powerful to most of the things.

The workflow is documented in that humongous tutorial page that I just shared, it's just you will have to figure out which pieces to keep and which are not relevant.

For instance, it's no longer sufficient to have SHA-1 keys and we need to move SHA-256, SHA -3 or whatever is suitable to us.

See http://www.pcworld.com/article/3174676/security/sha-1-collision-can-break-svn-code-repositories.html and

https://www.theregister.co.uk/2017/02/23/google_first_sha1_collision/

shirishag75 commented Mar 5, 2017

@mokun - if you are using eclipse as the IDE on MS-Windows, then this probably will be most instructive to you -

http://www.vogella.com/tutorials/EclipseGit/article.html .

I haven't had to use an IDE for anything, yet... and on GNU/Linux the CLI is pretty powerful to most of the things.

The workflow is documented in that humongous tutorial page that I just shared, it's just you will have to figure out which pieces to keep and which are not relevant.

For instance, it's no longer sufficient to have SHA-1 keys and we need to move SHA-256, SHA -3 or whatever is suitable to us.

See http://www.pcworld.com/article/3174676/security/sha-1-collision-can-break-svn-code-repositories.html and

https://www.theregister.co.uk/2017/02/23/google_first_sha1_collision/

@mokun

This comment has been minimized.

Show comment
Hide comment
@mokun

mokun Mar 5, 2017

Member

It's true that linux CLI is sufficient and the preferred choice for some developers.

To me, I'm so used to the windows environment that I've just ventured to see how differently in setting up the Eclipse IDE for accessing GH repo directly.

What I found out was that, instead of inputting "https://svn.code.sf.net/p/mars-sim/code" as repo root url, I just have to replace it with "https://github.com/mars-sim/mars-sim-git.git"

Then the rest of the steps are the same as said in https://github.com/mars-sim/mars-sim/wiki/Setting-Up-Eclipse-IDE

And viola ! Everything works just like before.

I'll update the wiki to reflect this url change.

Member

mokun commented Mar 5, 2017

It's true that linux CLI is sufficient and the preferred choice for some developers.

To me, I'm so used to the windows environment that I've just ventured to see how differently in setting up the Eclipse IDE for accessing GH repo directly.

What I found out was that, instead of inputting "https://svn.code.sf.net/p/mars-sim/code" as repo root url, I just have to replace it with "https://github.com/mars-sim/mars-sim-git.git"

Then the rest of the steps are the same as said in https://github.com/mars-sim/mars-sim/wiki/Setting-Up-Eclipse-IDE

And viola ! Everything works just like before.

I'll update the wiki to reflect this url change.

@larsnaesbye

This comment has been minimized.

Show comment
Hide comment
@larsnaesbye

larsnaesbye Mar 5, 2017

Contributor

What I found out was that, instead of inputting "https://svn.code.sf.net/p/mars-sim/code" as repo root url, I just have to replace it with "https://github.com/mars-sim/mars-sim-git.git"

Exactly. That was my point - you can still use Subversion if you wish, just with the GitHub repo :-)
And if you want to switch to git at one point, you can too.

Contributor

larsnaesbye commented Mar 5, 2017

What I found out was that, instead of inputting "https://svn.code.sf.net/p/mars-sim/code" as repo root url, I just have to replace it with "https://github.com/mars-sim/mars-sim-git.git"

Exactly. That was my point - you can still use Subversion if you wish, just with the GitHub repo :-)
And if you want to switch to git at one point, you can too.

@mokun

This comment has been minimized.

Show comment
Hide comment
@mokun

mokun Mar 5, 2017

Member

In summary,

A. If you stick with using SVN client,

  1. If you prefer graphical interface,
  1. If you prefer command line,

B. If you use Git for accessing GH repo,

  1. If you prefer graphical interface,
  • use any Eclipse IDE out there and you must install EGit plugin.
  • choose Approach 4 to set things up.

Note: will need to add Approach 4 in wiki later

  1. If you prefer command line,
  • install Git (for macOS or Linux) or GitHub Desktop (for windows).
Member

mokun commented Mar 5, 2017

In summary,

A. If you stick with using SVN client,

  1. If you prefer graphical interface,
  1. If you prefer command line,

B. If you use Git for accessing GH repo,

  1. If you prefer graphical interface,
  • use any Eclipse IDE out there and you must install EGit plugin.
  • choose Approach 4 to set things up.

Note: will need to add Approach 4 in wiki later

  1. If you prefer command line,
  • install Git (for macOS or Linux) or GitHub Desktop (for windows).
@larsnaesbye

This comment has been minimized.

Show comment
Hide comment
@larsnaesbye

larsnaesbye Mar 5, 2017

Contributor

Yes. That sounds like how the instructions should go :)

So...is mars-sim/mars-sim now the repo we use?

Contributor

larsnaesbye commented Mar 5, 2017

Yes. That sounds like how the instructions should go :)

So...is mars-sim/mars-sim now the repo we use?

@mokun

This comment has been minimized.

Show comment
Hide comment
@mokun

mokun Mar 5, 2017

Member

How do we clone what's in /mars-sim/mars-sim-git to /mars-sim/mars-sim while still retaining all the SVN commit history ?

Do you know of a way to do it ?

Please proceed if you already know how.

Member

mokun commented Mar 5, 2017

How do we clone what's in /mars-sim/mars-sim-git to /mars-sim/mars-sim while still retaining all the SVN commit history ?

Do you know of a way to do it ?

Please proceed if you already know how.

@mokun

This comment has been minimized.

Show comment
Hide comment
@mokun

mokun Mar 5, 2017

Member

@larsnaesbye and @shirishag75 ,

Can you verify if the instructions in https://github.com/mars-sim/mars-sim/wiki/Setting-Command-Line-Environment-via-SVN are correct ?

Feel free to edit.

Also, do you mind adding another wiki page showing users how to accomplish the same thing in Git instead of using SVN client ?

Member

mokun commented Mar 5, 2017

@larsnaesbye and @shirishag75 ,

Can you verify if the instructions in https://github.com/mars-sim/mars-sim/wiki/Setting-Command-Line-Environment-via-SVN are correct ?

Feel free to edit.

Also, do you mind adding another wiki page showing users how to accomplish the same thing in Git instead of using SVN client ?

@mokun

This comment has been minimized.

Show comment
Hide comment
@mokun

mokun Mar 5, 2017

Member

For instance, it's no longer sufficient to have SHA-1 keys and we need to move SHA-256, SHA -3 or whatever is suitable to us.

@shirishag75 ,

Can you open up a new issue regarding the adoption of SHA-256 keys ?

I don't know what needs to be done yet but we can surely explore further.

Member

mokun commented Mar 5, 2017

For instance, it's no longer sufficient to have SHA-1 keys and we need to move SHA-256, SHA -3 or whatever is suitable to us.

@shirishag75 ,

Can you open up a new issue regarding the adoption of SHA-256 keys ?

I don't know what needs to be done yet but we can surely explore further.

@shirishag75

This comment has been minimized.

Show comment
Hide comment
@shirishag75

shirishag75 Mar 5, 2017

@mokun Probably @larsnaesbye would be a better yet at the compiling. I do have maven at my end but haven't given stab yet at compiling unless all the other bits are in place -

[$] mvn -version                                                                                                                  
Apache Maven 3.3.9
Maven home: /usr/share/maven
Java version: 1.8.0_121, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.9.0-1-amd64", arch: "amd64", family: "unix"

For the git page, the only differences in command-line are -

$ git clone $URL.git 

$ git pull origin master

$ git branch $branch-name

(to get into branches, this is why git is in top, branching is faster and cheaper in git).

simply doing$ git branch --help tells all the different possibilities.

shirishag75 commented Mar 5, 2017

@mokun Probably @larsnaesbye would be a better yet at the compiling. I do have maven at my end but haven't given stab yet at compiling unless all the other bits are in place -

[$] mvn -version                                                                                                                  
Apache Maven 3.3.9
Maven home: /usr/share/maven
Java version: 1.8.0_121, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.9.0-1-amd64", arch: "amd64", family: "unix"

For the git page, the only differences in command-line are -

$ git clone $URL.git 

$ git pull origin master

$ git branch $branch-name

(to get into branches, this is why git is in top, branching is faster and cheaper in git).

simply doing$ git branch --help tells all the different possibilities.

@larsnaesbye

This comment has been minimized.

Show comment
Hide comment
@larsnaesbye

larsnaesbye Mar 7, 2017

Contributor

@mokun : It looks right to me. So this means we're in business on GH :-)

Contributor

larsnaesbye commented Mar 7, 2017

@mokun : It looks right to me. So this means we're in business on GH :-)

@mokun

This comment has been minimized.

Show comment
Hide comment
@mokun

mokun Mar 7, 2017

Member

Yes, now we have /mars-sim code repo working again !

In summary, I've been trying to figure out how to :

  1. Backup all Issues in /mars-sim repo and restore them in /mars-sim-git
  2. Backup all Wikis in /mars-sim repo and restore them in /mars-sim-git
    OR:
  3. Clone the codebase in /mars-sim-git repo and restore them in /mars-sim while keeping Commit History intact

We just need to do either 3, or 1 & 2 together.

At this moment, I haven't found an easy way to do 1.

I can do partially 2-- I can clone all wikis into my hard drive but I can't push them back to other repos.

I can do 3 except losing the releases/tags setup.

btw, I'd like to leave /mars-sim-0 and/or /mars-sim-git repos open for experimentation if that's okay for everyone.

This way, I may avoid accidentally screwing up /mars-sim repo, where all the important Wikis and Issues are resided.

Member

mokun commented Mar 7, 2017

Yes, now we have /mars-sim code repo working again !

In summary, I've been trying to figure out how to :

  1. Backup all Issues in /mars-sim repo and restore them in /mars-sim-git
  2. Backup all Wikis in /mars-sim repo and restore them in /mars-sim-git
    OR:
  3. Clone the codebase in /mars-sim-git repo and restore them in /mars-sim while keeping Commit History intact

We just need to do either 3, or 1 & 2 together.

At this moment, I haven't found an easy way to do 1.

I can do partially 2-- I can clone all wikis into my hard drive but I can't push them back to other repos.

I can do 3 except losing the releases/tags setup.

btw, I'd like to leave /mars-sim-0 and/or /mars-sim-git repos open for experimentation if that's okay for everyone.

This way, I may avoid accidentally screwing up /mars-sim repo, where all the important Wikis and Issues are resided.

@larsnaesbye

This comment has been minimized.

Show comment
Hide comment
@larsnaesbye

larsnaesbye Mar 7, 2017

Contributor

I might be able to do 2)...

But now we use mars-sim-git as main repo for commits, right? Just to be sure I get code changes into the right repo :-)

Contributor

larsnaesbye commented Mar 7, 2017

I might be able to do 2)...

But now we use mars-sim-git as main repo for commits, right? Just to be sure I get code changes into the right repo :-)

@mokun

This comment has been minimized.

Show comment
Hide comment
@mokun

mokun Mar 7, 2017

Member

But now we use mars-sim-git as main repo for commits, right? Just to be sure I get code changes into the right repo :-)

No, I did 3 and /mars-sim is now the official repo :)

Member

mokun commented Mar 7, 2017

But now we use mars-sim-git as main repo for commits, right? Just to be sure I get code changes into the right repo :-)

No, I did 3 and /mars-sim is now the official repo :)

@larsnaesbye

This comment has been minimized.

Show comment
Hide comment
@larsnaesbye

larsnaesbye Mar 8, 2017

Contributor

Perfect. Then our migration from SF to GH is done, I guess.

Contributor

larsnaesbye commented Mar 8, 2017

Perfect. Then our migration from SF to GH is done, I guess.

@larsnaesbye larsnaesbye closed this Mar 8, 2017

mokun added a commit that referenced this issue Apr 17, 2017

Combine Static Factory Method & Factory Builder
r3942
2017-04-16a

This commit is a part of project #4 at https://github.com/mars-sim/mars-sim/projects/4 

# NEW
1. Add create() as a Static Factory Method in Person. Use it to wrap 
   the calling of PersonBuilder.
   - Combine both the static factory method & factory builder pattern
   - Call Person.create() whenever instantiating a person.
2. Add two new class, namely RobotBuilder and RobotBuilderImpl 
   based on Factory Builder Pattern.
3. Add create() as a Static Factory Method in Robot. Use it to wrap 
   the calling of RobotBuilder.
   - Combine both the static factory method & factory builder pattern
   - Call Robot.create() whenever instantiating a robot.
   
# CHANGE
1. Keep only one constructor for Person & Robot. 
2. Change accessor modifier from public to protected for Person & Robot.
3. Update UnitManager, Resupply, ArrivingSettlement and numerous test 
   class with Person.create() when instantiating a Person.
4. Update UnitManager, Resupply & ArrivingSettlement with 
   Robot.create() when instantiating a Robot.
5. Remove returning robot in getEquipment() in EquipmentFactory.
   
CAVEAT: the only drawback in current implementation of Static Factory 
Method and Factory Builder Pattern is that one must manually add the 
calling of the "initialize()" method after a person/robot has just 
been instantiated in order to process with initializing the remaining 
characteristic/attributes of a person/robot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment