Permalink
Browse files

set_success really returns the status, there is no need

to return 1 for PLAIN authentication, otherwise this is
sent to the client which confuses some implementations.
  • Loading branch information...
1 parent 163888c commit 339f43b784f6549b0a7be97977e89835caddf942 @yannk yannk committed with gbarr Feb 11, 2009
Showing with 3 additions and 2 deletions.
  1. +1 −0 api.txt
  2. +2 −2 lib/Authen/SASL/Perl/PLAIN.pm
View
@@ -1,3 +1,4 @@
+
Client API
----------
Basically the Authen::SASL module gathers some info. When ->client_new
@@ -55,7 +55,7 @@ sub server_start {
if (defined $self->callback('checkpass')) {
if ($self->_call('checkpass', @parts{qw/user pass authname/}) ) {
$self->set_success;
- return 1;
+ return;
}
else {
return $self->set_error("Credentials don't match");
@@ -68,7 +68,7 @@ sub server_start {
unless $expected_pass eq ($parts{pass} || "");
$self->set_success;
- return 1;
+ return;
}
1;

0 comments on commit 339f43b

Please sign in to comment.