Permalink
Browse files

- Added maxbuf to the challenge (we should probably omit it when auth

  is proposed only, but that should be fine)
- Fixed an issue (I believe) where the client was looking for 'server-maxbuf'
  insted of 'maxbuf'
- renamed a test (consistency)
  • Loading branch information...
1 parent 9bc727d commit 37a9893a0a5be94e9867e3e364e0ebc0c0e9bdb3 @yannk yannk committed with gbarr Jan 14, 2009
@@ -13,7 +13,6 @@ use Digest::MD5 qw(md5_hex md5);
use Digest::HMAC_MD5 qw(hmac_md5);
# TODO: complete qop support in server, should be configurable
-# TODO: crypt layer support (maxbuf etc..)
$VERSION = "1.07";
@ISA = qw(Authen::SASL::Perl);
@@ -211,16 +210,16 @@ sub server_start {
charset => 'utf-8',
algorithm => 'md5-sess',
realm => $realm,
- #server-maxbuf XXX only if auth-conf
+ maxbuf => $self->property('maxbuf'),
## IN DRAFT ONLY:
# If this directive is present multiple times the client MUST treat
# it as if it received a single qop directive containing a comma
# separated value from all instances. I.e.,
# 'qop="auth",qop="auth-int"' is the same as 'qop="auth,auth-int"
- 'qop' => $qop,
- 'cipher' => [ map { $_->{name} } @ourciphers ],
+ 'qop' => $qop,
+ 'cipher' => [ map { $_->{name} } @ourciphers ],
);
return _response(\%response);
@@ -294,7 +293,7 @@ sub client_step { # $self, $server_sasl_credentials
return $self->set_error("Password is required")
unless defined $password;
- $self->property('maxout',$sparams{server_maxbuf} || 65536);
+ $self->property('maxout', $sparams{maxbuf} || 65536);
# Generate the response value
$self->{state} = 1;
File renamed without changes.
View
@@ -40,6 +40,7 @@ is($server->mechanism, 'DIGEST-MD5', 'conn mechanism');
'algorithm=md5-sess',
'charset=utf-8',
'cipher="rc4,3des,des,rc4-56,rc4-40"',
+ 'maxbuf=16777215',
'nonce="80338e79d2ca9b9c090ebaaa2ef293c7"',
'qop="auth"',
'realm="elwood.innosoft.com"';
@@ -72,6 +73,7 @@ is($server->mechanism, 'DIGEST-MD5', 'conn mechanism');
'algorithm=md5-sess',
'charset=utf-8',
'cipher="rc4,3des,des,rc4-56,rc4-40"',
+ 'maxbuf=16777215',
'nonce="80338e79d2ca9b9c090ebaaa2ef293c7"',
'qop="auth"',
'realm="elwood.innosoft.com"';
@@ -113,6 +115,7 @@ is($server->mechanism, 'DIGEST-MD5', 'conn mechanism');
'algorithm=md5-sess',
'charset=utf-8',
'cipher="rc4,3des,des,rc4-56,rc4-40"',
+ 'maxbuf=16777215',
'nonce="80338e79d2ca9b9c090ebaaa2ef293c7"',
'qop="auth,auth-conf,auth-int"',
'realm="elwood.innosoft.com"';

0 comments on commit 37a9893

Please sign in to comment.