Port logcat-color to Windows #7

Closed
tpsbuilder opened this Issue Jan 17, 2013 · 5 comments

Comments

Projects
None yet
3 participants
@tpsbuilder

This update to Jeff Sharkey's coloredlogcat.py looks like it only works on iOS.
Adrian Vintu made some changes to Jeff's original script to make it work on Windows.

I am working on some changes and may submit them as a Pull Request if I get the following changes working correctly:

  • The "logcat-color." file isn't directly usable in Windows and needs to be renamed to logcat-color.py"
  • All uses of python libraries fcntl and termios need to be isolated
  • FileLineReader's use of asyncore.file_wrapper(fd) needs a Windows equivalent.

Maybe resorting to Jeff and Adrian's original code as a Windows impl would suffice?

@marshall

This comment has been minimized.

Show comment Hide comment
@marshall

marshall Mar 11, 2013

Owner

The "logcat-color." file isn't directly usable in Windows and needs to be renamed to logcat-color.py

I'd be fine renaming logcat-color to logcat-color.py, we could just symlink as part of the installation.

All uses of python libraries fcntl and termios need to be isolated

I assume your pull request would handle this? :)

FileLineReader's use of asyncore.file_wrapper(fd) needs a Windows equivalent.

I think our only hope here is to switch away from asyncore, and use something based on libevent, possibly gevent

Owner

marshall commented Mar 11, 2013

The "logcat-color." file isn't directly usable in Windows and needs to be renamed to logcat-color.py

I'd be fine renaming logcat-color to logcat-color.py, we could just symlink as part of the installation.

All uses of python libraries fcntl and termios need to be isolated

I assume your pull request would handle this? :)

FileLineReader's use of asyncore.file_wrapper(fd) needs a Windows equivalent.

I think our only hope here is to switch away from asyncore, and use something based on libevent, possibly gevent

@crocodile

This comment has been minimized.

Show comment Hide comment
@crocodile

crocodile Apr 29, 2013

Would you share once you managed to get this working on Windows? I am keen to try this.

Please also consider adding a note to the readme section to save time for Windows users. Thanks.

Would you share once you managed to get this working on Windows? I am keen to try this.

Please also consider adding a note to the readme section to save time for Windows users. Thanks.

@marshall

This comment has been minimized.

Show comment Hide comment
@marshall

marshall Nov 26, 2013

Owner

@crocodile @tpsbuilder I've pushed my first attempt at porting logcat-color to win32 to a branch here: https://github.com/marshall/logcat-color/tree/win32

Unit tests are passing under Win8 + Python 2.7.6 for me. There is still some work to be done so that logcat-color is distributable in Windows, though. Let me know if this works for you,,

Owner

marshall commented Nov 26, 2013

@crocodile @tpsbuilder I've pushed my first attempt at porting logcat-color to win32 to a branch here: https://github.com/marshall/logcat-color/tree/win32

Unit tests are passing under Win8 + Python 2.7.6 for me. There is still some work to be done so that logcat-color is distributable in Windows, though. Let me know if this works for you,,

@ghost ghost assigned marshall Nov 27, 2013

@marshall

This comment has been minimized.

Show comment Hide comment
@marshall

marshall Nov 27, 2013

Owner

@crocodile @tpsbuilder I have made a 0.7.0preview release that includes a pre-built exe with all dependencies for Windows here:

https://github.com/marshall/logcat-color/releases/tag/v0.7.0preview

Owner

marshall commented Nov 27, 2013

@crocodile @tpsbuilder I have made a 0.7.0preview release that includes a pre-built exe with all dependencies for Windows here:

https://github.com/marshall/logcat-color/releases/tag/v0.7.0preview

@marshall

This comment has been minimized.

Show comment Hide comment
@marshall

marshall Nov 27, 2013

Owner

Closing this issue out. If you run into any issues with the preview release, just create a new issue :)

Owner

marshall commented Nov 27, 2013

Closing this issue out. If you run into any issues with the preview release, just create a new issue :)

@marshall marshall closed this Nov 27, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment