Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 2 support #491

Closed
sloria opened this issue Aug 31, 2019 · 7 comments · Fixed by #492

Comments

@sloria
Copy link
Member

commented Aug 31, 2019

Now that we're working on a new major apispec release, seems a good time as any to do this...

@sloria

This comment has been minimized.

Copy link
Member Author

commented Aug 31, 2019

@lafrech @Bangertm any objections?

@sloria

This comment has been minimized.

Copy link
Member Author

commented Aug 31, 2019

We can also probably drop support for Python 3.5. Usage is very low among marshmallow users (even lower than Python 2!): http://marshmallow.sloria.io/#ma2-vs-ma3-pyminor

@sloria

This comment has been minimized.

Copy link
Member Author

commented Aug 31, 2019

Summoning @hugovk: slayer of python 2-compatible code

@hugovk

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2019

I'll make a PR!

@lafrech

This comment has been minimized.

Copy link
Member

commented Sep 1, 2019

No pb with dropping PY2.

https://pythonclock.org/

We run our apps on Debian. Buster is out and it ships PY3.7 but some apps still run on Stretch with PY3.5 and porting them to Buster is not absolutely trivial so if there's no great benefit from dropping 3.5, I'd rather keep it.

Since we allow ourselves more frequent major updates for apispec/webargs than for marshmallow, we can always drop it later on.

@hugovk

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2019

I included dropping 3.5 in #492, but I don't see a great benefit so can adjust it tomorrow to only drop 2.7.

@sloria

This comment has been minimized.

Copy link
Member Author

commented Sep 1, 2019

Yep, I'm fine with supporting 3.5 for now. Thanks @hugovk for working on this (again).

@sloria sloria closed this in #492 Sep 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.