Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flask extension does not support application root #69

Closed
deckar01 opened this issue Apr 27, 2016 · 2 comments

Comments

@deckar01
Copy link
Member

commented Apr 27, 2016

The flask extension only outputs the route path, but flask.url_for() takes into consideration that the path should be prefixed with the configured APPLICATION_ROOT path. apispec/ext/flask.py#L58

@sloria

This comment has been minimized.

Copy link
Member

commented Apr 28, 2016

Thanks for reporting.

I would welcome a PR for this.

@deckar01

This comment has been minimized.

Copy link
Member Author

commented Apr 28, 2016

Looking into the implementation. 👓

I would like to lean on the url_adapter interface as much as possible to avoid replicating the internal implementation of flask and insulate the extension against future changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.