Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass operations to downstream extension #138

Merged

Conversation

@yoichi
Copy link
Collaborator

commented Jul 14, 2017

As I commented in #134 ,
even if preceding extension construct 'operations', it won't be used in ext.marshmallow to resolve Schema class.
I've added a test to illustrate the problem (yoichi@833724a), then fix it (yoichi@fdd97dd).

Regards,

yoichi added some commits Jul 14, 2017

add test for marshmallow extension used with tornado extension
it fails as:
>       assert response['schema'] == swagger.schema2jsonschema(PetSchema)
E       AssertionError: assert 'tests.schemas.PetSchema' == {'properties': {'id': {'type': 'integer', 'format': 'int32', 'readOnly': True}, 'name': {'type': 'string'}}, 'type': 'object'}
E        +  where {'properties': {'id': {'type': 'integer', 'format': 'int32', 'readOnly': True}, 'name': {'type': 'string'}}, 'type': 'object'} = <function schema2jsonschema at 0x11149a400>(PetSchema)
E        +    where <function schema2jsonschema at 0x11149a400> = swagger.schema2jsonschema

tests/test_ext_tornado_marshmallow.py:48: AssertionError
@sloria

This comment has been minimized.

Copy link
Member

commented Jul 22, 2017

Looks correct. Thanks!

@sloria sloria merged commit 3b48694 into marshmallow-code:dev Jul 22, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.