Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swagger location mapping for default_in param in property2parameter #142

Merged
merged 1 commit into from Aug 9, 2017

Conversation

@decaz
Copy link
Contributor

commented Aug 8, 2017

Also "cookies" -> "cookie" swagger location mapping was added.

@decaz decaz force-pushed the decaz:fix-location-mapping branch from 2e64561 to 977b868 Aug 8, 2017

@sloria

This comment has been minimized.

Copy link
Member

commented Aug 8, 2017

Thanks @decaz ! Would you mind adding a regression test for this change? That would greatly help me to understand this fix.

@decaz decaz force-pushed the decaz:fix-location-mapping branch from 977b868 to b5e93a9 Aug 8, 2017

@decaz

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2017

@sloria done!

@sloria

This comment has been minimized.

Copy link
Member

commented Aug 8, 2017

Thanks! I'll review and release this fix when I'm off of work today.

@sloria sloria merged commit 0c03dcf into marshmallow-code:dev Aug 9, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.