Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow helpers to return None #336

Merged
merged 3 commits into from Nov 6, 2018

Conversation

@lafrech
Copy link
Member

commented Nov 6, 2018

Fixes #331.

@lafrech lafrech added this to the 1.0 milestone Nov 6, 2018

@lafrech

This comment has been minimized.

Copy link
Member Author

commented Nov 6, 2018

@sloria, @Bangertm, any comment before I merge this?

@lafrech lafrech requested review from sloria and Bangertm Nov 6, 2018

@Bangertm
Copy link
Collaborator

left a comment

Looks good. Tested with the api that was causing the problem and it works great.

@lafrech

This comment has been minimized.

Copy link
Member Author

commented Nov 6, 2018

Alright, let's merge this. It's never too late to rework the CHANGELOG if it is unclear.

@lafrech lafrech merged commit 3f25523 into dev Nov 6, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@lafrech lafrech deleted the dev_helpers_return_none branch Nov 6, 2018

@sloria

This comment has been minimized.

Copy link
Member

commented Nov 7, 2018

Thanks guys. Since this is a bugfix, looks like it's time to release! 🚢 🇮🇹

I'll get #338 merged in then cut a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.