Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for outputting field patterns #364

Merged

Conversation

@DStape
Copy link
Contributor

commented Jan 28, 2019

No description provided.

@sloria
Copy link
Member

left a comment

Thanks for the PR!

Just a couple suggestions.

apispec/ext/marshmallow/openapi.py Outdated Show resolved Hide resolved
tests/test_openapi.py Show resolved Hide resolved

@DStape DStape force-pushed the DStape:add-support-for-outputting-regex-pattern branch from e6f00ba to a8f02c3 Feb 1, 2019

@DStape DStape force-pushed the DStape:add-support-for-outputting-regex-pattern branch from a8f02c3 to 3980709 Feb 2, 2019

@DStape

This comment has been minimized.

Copy link
Contributor Author

commented Feb 2, 2019

Just rebased, which should fix the failing CI build.

@sloria

sloria approved these changes Feb 2, 2019

Copy link
Member

left a comment

Made a tiny improvement to the warning message and test.

Thanks @DStape for updating this. Good to merge after Travis is green.

@sloria sloria merged commit 2112fea into marshmallow-code:dev Feb 2, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sloria sloria added this to the 1.0 milestone Feb 2, 2019

@DStape

This comment has been minimized.

Copy link
Contributor Author

commented Feb 2, 2019

No problem @sloria, thanks for merging!

@DStape DStape deleted the DStape:add-support-for-outputting-regex-pattern branch Feb 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.