Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for observed field names. #48

Merged
merged 3 commits into from Feb 6, 2016

Conversation

@benbeadle
Copy link
Contributor

commented Jan 29, 2016

When the field is required, the observed field name should be used instead of the real field name.

@sloria - I couldn't figure out how to edit the other pull request, so I created a new request with the added regression test you asked for in #47.

benbeadle added some commits Jan 29, 2016

Bug fix for observed field names.
When the field is required, the observed field name should be used instead of the real field name.
Added test for required field with observed name
Added regression test for required field with an observed field name.
Update test_swagger.py
Changed to dictionary since Schema isn't iterable.

@sloria sloria added this to the 0.5.0 milestone Feb 6, 2016

@sloria

This comment has been minimized.

Copy link
Member

commented Feb 6, 2016

Thanks!

sloria added a commit that referenced this pull request Feb 6, 2016

Merge pull request #48 from benbeadle/dev
Bug fix for observed field names.

@sloria sloria merged commit c2be2af into marshmallow-code:dev Feb 6, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sloria sloria removed this from the 0.5.0 milestone Feb 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.