Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clean_parameters and clean_operations APISpec methods #489

Merged
merged 1 commit into from Sep 1, 2019

Conversation

@lafrech
Copy link
Member

commented Aug 31, 2019

Alternative to #466.

@sloria
sloria approved these changes Aug 31, 2019
self._paths[path]["parameters"] = parameters
return self

@staticmethod
def get_ref(obj_type, obj, openapi_major_version):

This comment has been minimized.

Copy link
@sloria

sloria Aug 31, 2019

Member

Can you make this an instance method and get ride of the openapi_major_version arg?

This comment has been minimized.

Copy link
@lafrech

lafrech Sep 1, 2019

Author Member

Good catch. Done.

return obj
return build_reference(obj_type, openapi_major_version, obj)

def clean_parameters(self, parameters, openapi_major_version):

This comment has been minimized.

Copy link
@sloria

sloria Aug 31, 2019

Member

Same here: get ride of openapi_major_version?

@lafrech lafrech force-pushed the clean_functions_apispec_methods branch from 6a26e2b to c93fc99 Sep 1, 2019
@lafrech lafrech merged commit 6157335 into dev Sep 1, 2019
11 checks passed
11 checks passed
marshmallow-code.apispec Build #20190901.3 succeeded
Details
marshmallow-code.apispec (tox_linux docs) tox_linux docs succeeded
Details
marshmallow-code.apispec (tox_linux lint) tox_linux lint succeeded
Details
marshmallow-code.apispec (tox_linux py27-marshmallow2) tox_linux py27-marshmallow2 succeeded
Details
marshmallow-code.apispec (tox_linux py35-marshmallow2) tox_linux py35-marshmallow2 succeeded
Details
marshmallow-code.apispec (tox_linux py35-marshmallow3) tox_linux py35-marshmallow3 succeeded
Details
marshmallow-code.apispec (tox_linux py36-marshmallow2) tox_linux py36-marshmallow2 succeeded
Details
marshmallow-code.apispec (tox_linux py36-marshmallow3) tox_linux py36-marshmallow3 succeeded
Details
marshmallow-code.apispec (tox_linux py37-marshmallow2) tox_linux py37-marshmallow2 succeeded
Details
marshmallow-code.apispec (tox_linux py37-marshmallow3) tox_linux py37-marshmallow3 succeeded
Details
marshmallow-code.apispec (tox_linux py37-marshmallowdev) tox_linux py37-marshmallowdev succeeded
Details
@lafrech lafrech deleted the clean_functions_apispec_methods branch Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.