Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract SchemaResolver from MarshmallowPlugin #496

Merged
merged 2 commits into from Sep 13, 2019

Conversation

@Bangertm
Copy link
Collaborator

commented Sep 6, 2019

Extracts logic for resolving schemas in OpenAPI objects and enhannces documentation.

Might have gone a little bit overboard on the documentation, but I thought it would helpful to provide concrete examples of how to construct dictionaries for conversion.

Enhannces documentation
Copy link
Member

left a comment

Just drive-by nits. Will probably leave this up to @lafrech to give the

src/apispec/ext/marshmallow/schema_resolver.py Outdated Show resolved Hide resolved
src/apispec/ext/marshmallow/schema_resolver.py Outdated Show resolved Hide resolved
src/apispec/ext/marshmallow/schema_resolver.py Outdated Show resolved Hide resolved
@lafrech

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

I don't really see a benefit to this change. It's does not help customizing (subclassing), for instance, like the other alike changes we introduced recently do.

But I see no objection either.

We can merge this, if only for the added documentation.

Would this be the last change before we release v3.0?

@lafrech

This comment has been minimized.

Copy link
Member

commented Sep 13, 2019

Nits fixed.

So, @sloria @Bangertm, we merge this and #501 and we ship a 3.0?

@sloria

This comment has been minimized.

Copy link
Member

commented Sep 13, 2019

Sounds good to me

@lafrech lafrech merged commit e02501e into dev Sep 13, 2019
10 checks passed
10 checks passed
marshmallow-code.apispec Build #20190913.2 succeeded
Details
marshmallow-code.apispec (tox_linux docs) tox_linux docs succeeded
Details
marshmallow-code.apispec (tox_linux lint) tox_linux lint succeeded
Details
marshmallow-code.apispec (tox_linux py35-marshmallow2) tox_linux py35-marshmallow2 succeeded
Details
marshmallow-code.apispec (tox_linux py35-marshmallow3) tox_linux py35-marshmallow3 succeeded
Details
marshmallow-code.apispec (tox_linux py36-marshmallow2) tox_linux py36-marshmallow2 succeeded
Details
marshmallow-code.apispec (tox_linux py36-marshmallow3) tox_linux py36-marshmallow3 succeeded
Details
marshmallow-code.apispec (tox_linux py37-marshmallow2) tox_linux py37-marshmallow2 succeeded
Details
marshmallow-code.apispec (tox_linux py37-marshmallow3) tox_linux py37-marshmallow3 succeeded
Details
marshmallow-code.apispec (tox_linux py37-marshmallowdev) tox_linux py37-marshmallowdev succeeded
Details
@lafrech lafrech deleted the extract-schema-resolver branch Sep 13, 2019
@lafrech

This comment has been minimized.

Copy link
Member

commented Sep 13, 2019

Alright. Merged.

I shall release 3.0 this WE or beginning of next week.

Do we need to add a changelog entry for all those refactors (FieldConverterMixin, SchemaResolver, cleaner functions becoming APISpec methods)? Could some of them be considered breaking changes?

@lafrech

This comment has been minimized.

Copy link
Member

commented Sep 17, 2019

@sloria, @Bangertm, I just updated the CHANGELOG and pushed 3.0.0!

@sloria

This comment has been minimized.

Copy link
Member

commented Sep 17, 2019

Awesome! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.