New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update hyperlinkrelated to gracefully support nullable / non-required sqla relations #72
Conversation
Sure. @feigner Would you mind getting this up to date with |
Yes, I can take care of this soon
Sent from a TI-89.
… On Feb 11, 2019, at 08:05, Steven Loria ***@***.***> wrote:
Sure. @feigner Would you mind getting this up to date with dev (rebase or merge are fine)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
6760de8
to
75ced3c
Compare
75ced3c
to
8db469e
Compare
@feigner Thanks for getting this up to date. I'm unsure how this will affect partial loading. Can you add a test for it? |
Happy to write some more tests. I've read the linked docs, but I'm not entirely sure what you'd like me to verify. Can you give me an example use case of what you'd like to see? |
Oh, didn't realize this only changes serialization behavior, so partial loading isn't relevant here. However, I'm not sure about the I think the most consistent behavior would be to serialize |
For consistency with other fields close #72
Upon looking this over again, I think this isn't the right approach for the reason I mentioned above. |
I have nullable relations on my SQLAlchemy models that blow up when deserializing HyperlinkRelated. Patch allows for graceful failure when base field is not-required.
Similar to the issue listed here: #18