Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use with sqlalchemy-1.1 and JSON field type #74

Closed
ewittle opened this issue Jul 27, 2016 · 1 comment

Comments

@ewittle
Copy link
Contributor

commented Jul 27, 2016

If you use sqlalchemy 1.1 (b2 in my case) with the new JSON field type, you'll get a type conversion error:

marshmallow_sqlalchemy.exceptions.ModelConversionError: Could not find field column of type <class 'sqlalchemy.sql.sqltypes.JSON'>.

In Convert.py, I added ",
sa.JSON: fields.Raw" to the end of SQLA_TYPE_MAPPING in class ModelConverter, and that seems to do the trick (at least so far)

@ewittle

This comment has been minimized.

Copy link
Contributor Author

commented Jul 29, 2016

Created a pull request for the change, modified the approach describe above a bit to avoid causing issues with versions of SQLAlchemy prior to 1.1. Tried to follow the contributions instructions, let me know what I missed.

@sloria sloria closed this Jul 31, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.