Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fields: Add RelatedList to handle attribute correctly #150

Merged
merged 1 commit into from Nov 3, 2018

Conversation

@AbdealiJK
Copy link
Collaborator

commented Oct 20, 2018

Fixes #121

@AbdealiJK

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 20, 2018

Travis failure seems to be unrelated to this patch

@sloria

This comment has been minimized.

Copy link
Member

commented Oct 26, 2018

Thanks @AbdealiJK . I'll try to take a look at this when I get some time over the next few days

@AbdealiJK

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 3, 2018

@sloria any thoughts on this ? I currently have a fork Im maintaining for this fix internally but would prefer solving upstream so I do not need to have a fork :)

@sloria

sloria approved these changes Nov 3, 2018

@sloria

This comment has been minimized.

Copy link
Member

commented Nov 3, 2018

Apologies for the delay. Behavior looks good. Good to merge!

@sloria sloria merged commit af41e19 into marshmallow-code:dev Nov 3, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@sloria

This comment has been minimized.

Copy link
Member

commented Nov 3, 2018

By the way, I'm starting to use something along the lines of the Pull Request Hack. Basically, if you get a PR merged in, you get an invite to have commit access.

No pressure to do any more work than you already have. Just want to open the door to further collaboration. =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.