New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UUID field raises ValueError on malformed UUID when deserializing #106

Closed
vesauimonen opened this Issue Dec 17, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@vesauimonen
Contributor

vesauimonen commented Dec 17, 2014

The following code results in a ValueError: badly formed hexadecimal UUID string exception.

from marshmallow import fields, Schema

class ExampleSchema(Schema):
    id = fields.UUID()

schema = ExampleSchema()
schema.load({'id': 'malformed'})

I'm working on a bug fix. Do you want it to be sent to dev branch? I'm not seeing a maintenance branch as described in https://github.com/sloria/marshmallow/blob/dev/CONTRIBUTING.rst#git-branch-structure.

@sloria

This comment has been minimized.

Member

sloria commented Dec 17, 2014

Thank you for reporting and fixing this. Yes, you can send the PR to dev; I haven't yet finalized the branch structured described in the contributing docs.

vesauimonen added a commit to vesauimonen/marshmallow that referenced this issue Dec 17, 2014

Handle exceptions in UUID deserialization
UUID deserialization raised unexpected exceptions with malformed
values. Refs marshmallow-code#106.
@sloria

This comment has been minimized.

Member

sloria commented Dec 19, 2014

Fixed by #107

@sloria sloria closed this Dec 19, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment