Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 2.6 in marshmallow 2 #1274

Closed
sloria opened this issue Jul 1, 2019 · 5 comments

Comments

@sloria
Copy link
Member

commented Jul 1, 2019

Python 2.6 has been EOL since 2013.
The Python 2.6 build is currently broken, and I've not the motivation to fix it.
In the past 30 days, there's been only 1--exactly 1--non-Linux download of marshmallow 2 on Python 2.6.

image

I think it's past time we drop official Python 2.6 support in marshmallow 2. We don't need to change the code--just stop testing against it.

Moving forward, I think we should keep the policy of dropping Python versions iff they are past their EOL date and have low usage (this will be a judgment call).

Any objections, @lafrech @deckar01 ?

@sloria sloria referenced this issue Jul 1, 2019
@hugovk

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2019

Here's the pip installs for all marshmallow versions from PyPI for June 2019, showing very low numbers for 2.6:

category percent downloads
3.6 35.79% 398,246
2.7 34.81% 387,385
3.7 21.40% 238,157
3.5 6.28% 69,934
3.4 0.97% 10,846
null 0.69% 7,708
2.6 0.02% 241
3.8 0.02% 193
3.3 0.00% 10
3.9 0.00% 1
Total 1,112,721

Source: pypistats python_minor marshmallow --last-month # pip install pypistats

@sloria

This comment has been minimized.

Copy link
Member Author

commented Jul 1, 2019

Yeah, the vast majority of the 2.6 installs are probably CI builds, which is why I counted non-Linux downloads in my OP.

sloria added a commit that referenced this issue Jul 2, 2019
@lafrech

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

This project is maintained by volunteers. Someone willing to run an unmaintained Python version, especially one that has been unmaintained for years, either doesn't mind unmaintained stuff and won't update his marshmallow version, or spends a lot of money or time maintaining Python and other libs and he can add marshmallow to the list. There's no point carrying that burden ourselves.

Moving forward, I think we should keep the policy of dropping Python versions iff they are past their EOL date and have low usage (this will be a judgment call).

This.

(Besides, this policy allows us to keep PY3.5 in MA3 for now with an open door to drop it when it's EOLed without waiting for MA4. We could make it clear right away in the docs or changelog. Is there a known good practice / convention about this?)

sloria added a commit that referenced this issue Jul 2, 2019
@sloria

This comment has been minimized.

Copy link
Member Author

commented Jul 2, 2019

A cursory review of other mature projects shows that the above policy is common. I agree it would be good to document somewhere. Will do that when I have some extra time.

sloria added a commit that referenced this issue Jul 6, 2019
sloria added a commit that referenced this issue Jul 6, 2019

@sloria sloria closed this Jul 6, 2019

@sloria

This comment has been minimized.

Copy link
Member Author

commented Jul 13, 2019

I put together a little dashboard that should help with these decisions in the future: https://marshmallow.sloria.io/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.