New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Method hooks swallow AttributeError #395
Comments
This is super annoying... and should at least come with a way to switch off this behaviour for debugging purposes. |
I intend to look into solutions for this in marshmallow 3.0 |
I don't understand the original reasons for writing it this way, except that attribute-based field types are omitted if the attribute is missing. Options might be:
|
As mentioned in #582 :
If there's interest in getting this fixed in 2.0, I can look into merging #582, but I'd rather users just upgrade to 3.0. |
This is addressed in 54f731d |
...and fix some errors found by flake8
It didn't correctly handle values other than a comma-separated string nor empty strings A combination of bugs in the tests, the load_references method and marshmallow 2.13.6 made the test altough the implementation was incorrect. See marshmallow-code/marshmallow#395 for more info on the marshmallow bug
If
AttributeError
is raised by aMethod
/Function
hook, it is silently swallowed:This makes finding the bugs harder. I understand the rationale and I guess fixing it might make some code backward incompatible, but is there a way to add at least some warning mode?
The text was updated successfully, but these errors were encountered: