New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema error_kwargs aren't reset! #565

Closed
jbasko opened this Issue Dec 19, 2016 · 0 comments

Comments

Projects
None yet
2 participants
@jbasko
Contributor

jbasko commented Dec 19, 2016

In ErrorStore, error_kwargs aren't reset unlike other error fields.

This is a critical issue as depending on how one uses ValidationError.kwargs, one could potentially expose a user's error information to another user making a request later.

P.S. I never saw any warnings in documentation against reusing Schema instances, so I am using same instance to serve more than just one request.

I created a PR:
#564

@sloria sloria closed this Dec 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment