New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy API #73

Closed
sloria opened this Issue Dec 4, 2014 · 7 comments

Comments

Projects
None yet
2 participants
@sloria
Member

sloria commented Dec 4, 2014

In version 2.0, the pre-1.0 legacy API will be completely removed from the codebase.

This includes:

  • Passing object to be serialized to Schema constructor
  • data and errors properties of Schema
  • The error param of Fields (still in question)
  • Arbitrary, Fixed and Price fields (remove in 2.0)
  • Select field (remove in 2.0)
  • Deprecated function validators. Alias validator classes?
  • context argument of Method fields? (in question)
  • @Schema.preprocessor, @Schema.data_handler, etc.
  • MarshallingError and UnmarshallingError (remove in 2.1)
  • QuerySelect and QuerySelectList (remove in 2.2)
  • allow_none and required string arguments (remove in 2.2)

EDIT: Updated checklist based on comments.

@sloria sloria added this to the 2.0 milestone Dec 4, 2014

@sloria sloria added the refactor label Jan 18, 2015

@sloria

This comment has been minimized.

Member

sloria commented Jan 18, 2015

The Arbitrary, Fixed, and Price fields may also be removed in favor of the Decimal field.

@sloria

This comment has been minimized.

Member

sloria commented Jan 18, 2015

Also, the deprecated function validators in the validate module.

@philtay

This comment has been minimized.

Contributor

philtay commented Feb 14, 2015

Also, deprecate/remove the Select field in favor of OneOf validator.

@sloria

This comment has been minimized.

Member

sloria commented Feb 17, 2015

Let's do this for the final release of 2.0.0 (rather than in 2.0.0-a) to ease the transition to the 2.0 line.

@sloria sloria modified the milestones: 2.0.0 (final), 2.0-a Feb 17, 2015

sloria added a commit that referenced this issue Mar 1, 2015

@sloria

This comment has been minimized.

Member

sloria commented Mar 1, 2015

Went ahead and removed Schema.data and Schema.errors, as it is has been deprecated since 1.0.

@sloria sloria changed the title from Remove legacy (pre-1.0) API to Remove legacy API Mar 1, 2015

@philtay

This comment has been minimized.

Contributor

philtay commented Mar 1, 2015

Add the deprecated function validators in the checklist.

@sloria

This comment has been minimized.

Member

sloria commented Mar 2, 2015

Done.

@sloria sloria removed this from the 2.0.0 (final) milestone Apr 30, 2015

sloria added a commit that referenced this issue Jul 8, 2015

@sloria sloria added this to the 2.0.0 (final) milestone Aug 25, 2015

sloria added a commit that referenced this issue Sep 13, 2015

@sloria sloria modified the milestones: 2.1, 2.0.0 (final) Sep 17, 2015

sloria added a commit that referenced this issue Sep 19, 2015

Remove legacy fields
- Arbitrary
- Price
- Fixed
- Select/Enum

ref #73

sloria added a commit that referenced this issue Oct 8, 2015

sloria added a commit that referenced this issue Oct 8, 2015

Remove passing strings to required and allow_none
Also document how to customize error messages

ref #73

@sloria sloria closed this Oct 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment