New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require_tld option of validate.URL is missing for fields.URL #749

Closed
DenisKuplyakov opened this Issue Mar 5, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@DenisKuplyakov

DenisKuplyakov commented Mar 5, 2018

See subj. There is no way to pass require_tld to underlying validate when using fields.URL.

@deckar01 deckar01 added the enhancement label Apr 4, 2018

@deckar01

This comment has been minimized.

Member

deckar01 commented Apr 4, 2018

The validator was implemented in #674. It looks like there was originally some hesitation to add it to the field in #665 and it was closed for backwards compatibility reasons. I don't see any reason why it would be backwards incompatible. It should be safe to add another parameter before the kwargs.

We might be able to add it to v2. We can add it to v3. You will probably need to copy the url field implementation to a custom field with the extra argument supplied for now.

http://marshmallow.readthedocs.io/en/stable/custom_fields.html#custom-fields

@lafrech

This comment has been minimized.

Member

lafrech commented May 2, 2018

Should Email have a require_tld parameter as well?

@sloria

This comment has been minimized.

Member

sloria commented May 15, 2018

Closed by #765 . @lafrech Let's defer on adding require_tld to Email for now, since there insn't a corresponding param for validate.Email.

@sloria sloria closed this May 15, 2018

@sloria sloria added this to the 3.0 milestone May 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment