New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAISE should be default for Nested() #908

Closed
tuukkamustonen opened this Issue Aug 8, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@tuukkamustonen
Contributor

tuukkamustonen commented Aug 8, 2018

Isn't it a bit weird that Schema defaults to RAISE but Nested defaults to EXCLUDE?

It's probably not what one expects (at least I didn't). How about changing the default? Or what might be the reasoning?

@sloria

This comment has been minimized.

Member

sloria commented Aug 8, 2018

Good catch @tuukkamustonen . This may have been an oversight. @lafrech Was the default intentionally left as EXCLUDE for Nested in #872 ?

tuukkamustonen added a commit to tuukkamustonen/marshmallow that referenced this issue Aug 9, 2018

@lafrech

This comment has been minimized.

Member

lafrech commented Aug 14, 2018

Oops, nope. I guess I missed that one. Sorry about that.

@lafrech lafrech added the bug label Aug 14, 2018

@lafrech lafrech added this to the 3.0 milestone Aug 14, 2018

tuukkamustonen added a commit to tuukkamustonen/marshmallow that referenced this issue Aug 30, 2018

tuukkamustonen added a commit to tuukkamustonen/marshmallow that referenced this issue Aug 30, 2018

tuukkamustonen added a commit to tuukkamustonen/marshmallow that referenced this issue Aug 30, 2018

tuukkamustonen added a commit to tuukkamustonen/marshmallow that referenced this issue Sep 3, 2018

@lafrech lafrech closed this in 8a3f327 Sep 3, 2018

lafrech added a commit that referenced this issue Sep 3, 2018

Merge pull request #911 from tuukkamustonen/908-raise-as-default-unkn…
…own-for-nested

Fixes #908: Nested field default unknown to RAISE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment