Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Let all fields _deserialize method accept **kwargs #1007
Following up on #849. I think this makes things more consistent.
Adding a note to the docs saying
I'm tempted to do the same to
So you'd rather have a strict interface where
pylint complains when changing a method signature when subclassing as it is considered bad practice, I suppose.
It will break custom fields not accepting kwargs. Doesn't this qualify as a breaking change?
I see what you mean. I was stuck thinking about field inheritance and subclasses calling our base class methods. The issue is the marshaller calling custom fields'
Since these methods are only expected to be called by us internally, there is no need to protect ourselves from passing a kwargs to a custom field that doesn't do anything with it.