New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loads should use the schema's many value by default #108

Merged
merged 1 commit into from Dec 20, 2014

Conversation

Projects
None yet
2 participants
@davidism
Contributor

davidism commented Dec 19, 2014

When a schema is initialized with many=True, dump, load, and dumps will use that value by default, but loads defaults to False. The user must explicitly pass True in order to use the same schema instance for dumping and loading. All the methods should present the same default behavior to avoid confusion.

No tests failed by making this change, but I added a simple test anyway. There are no asserts because simply trying to call loads on data dumped by the same schema instance will cause an exception.

@sloria sloria merged commit 2d7d49d into marshmallow-code:dev Dec 20, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@sloria

This comment has been minimized.

Member

sloria commented Dec 20, 2014

Good catch!

@davidism davidism deleted the davidism:loads_many branch Dec 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment