Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behavior when passing nested instance and `only` #1395

Merged
merged 2 commits into from Sep 13, 2019

Conversation

@sloria
Copy link
Member

commented Sep 13, 2019

#1385 introduced a regression with passing an instance to Nested along with only e.g.

artist = fields.Nested(ArtistSchema(), only=('name', ))
artist_name = fields.Pluck(ArtistSchema(), "name")
sloria added 2 commits Sep 13, 2019
@sloria sloria merged commit 8e4e746 into dev Sep 13, 2019
6 checks passed
6 checks passed
marshmallow-code.marshmallow Build #20190913.2 succeeded
Details
marshmallow-code.marshmallow (tox_linux docs) tox_linux docs succeeded
Details
marshmallow-code.marshmallow (tox_linux lint) tox_linux lint succeeded
Details
marshmallow-code.marshmallow (tox_linux py35) tox_linux py35 succeeded
Details
marshmallow-code.marshmallow (tox_linux py36) tox_linux py36 succeeded
Details
marshmallow-code.marshmallow (tox_linux py37) tox_linux py37 succeeded
Details
@sloria sloria deleted the fix-nested-instance branch Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.