Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved strict mode; ValidationError; Deprecate UnmarshallingError and MarshallingError (issue #160) #168

Merged
merged 16 commits into from Mar 16, 2015
Merged

Improved strict mode; ValidationError; Deprecate UnmarshallingError and MarshallingError (issue #160) #168

merged 16 commits into from Mar 16, 2015

Conversation

sloria
Copy link
Member

@sloria sloria commented Mar 14, 2015

Removes UnmarshallingError, MarshallingError and all the unnecessary logic associated with them in favor of a single ValidationError. (#160)

Also, in strict mode, a ValidationError's messages attribute will contain the full errors dictionary. (#128).

TODO:

  • Expand tests
  • Document migration page
  • Update changelog

@sloria sloria added this to the 2.0-a milestone Mar 15, 2015
@sloria sloria changed the title WIP: Remove UnmarshallingError and MarshallingError (issue #160) WIP: Improved strict mode; Remove UnmarshallingError and MarshallingError (issue #160) Mar 16, 2015
@sloria sloria changed the title WIP: Improved strict mode; Remove UnmarshallingError and MarshallingError (issue #160) Remove UnmarshallingError and MarshallingError (issue #160) Mar 16, 2015
@sloria sloria changed the title Remove UnmarshallingError and MarshallingError (issue #160) Improved strict mode; ValidationError; Remove UnmarshallingError and MarshallingError (issue #160) Mar 16, 2015
@sloria sloria changed the title Improved strict mode; ValidationError; Remove UnmarshallingError and MarshallingError (issue #160) Improved strict mode; ValidationError; Deprecate UnmarshallingError and MarshallingError (issue #160) Mar 16, 2015
sloria added a commit that referenced this pull request Mar 16, 2015
@sloria
Merge pull request #168 from marshmallow-code/validation-error
f55611d 
Improved strict mode; ValidationError; Deprecate UnmarshallingError and MarshallingError (issue #160)
@sloria sloria merged commit f55611d into dev Mar 16, 2015
@sloria sloria deleted the validation-error branch April 22, 2015 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0-a
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@sloria