New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated utils._get_value_for_key return the called attribute if it is callable #242

Merged
merged 1 commit into from Jul 16, 2015

Conversation

Projects
None yet
2 participants
@alexmorken

alexmorken commented Jul 15, 2015

I believe this should be the behavior expected. While most things can be made an @Property, sometimes they aren't and it is great to be able to get the result back.

@sloria

This comment has been minimized.

Member

sloria commented Jul 16, 2015

I agree. Thanks!

sloria added a commit that referenced this pull request Jul 16, 2015

Merge pull request #242 from alexmorken/bugfix/make_callable_attribut…
…es_marshallable

Updated utils._get_value_for_key return the called attribute if it is callable

@sloria sloria merged commit 9844f9d into marshmallow-code:dev Jul 16, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

sloria added a commit that referenced this pull request Feb 19, 2017

Don't call attributes unconditionally
closes :issue:`430`

reverts #242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment