New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary raising of ValidationError in unmarshaller #360

Merged
merged 1 commit into from Dec 9, 2015

Conversation

Projects
None yet
2 participants
@alexmorken

alexmorken commented Dec 9, 2015

The validation error does not need to be thrown because it is already being picked up. Most of the time the error message was stomping on itself and it was not noticeable bug. The only time this would come up is if a nested schema had a validation error and an index was being tacked on the beginning of the error - then the error would appear twice, once indexed and the other not indexed. This is a tricky area that should be cleaned up more.

@sloria sloria merged commit 3062289 into marshmallow-code:dev Dec 9, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sloria

This comment has been minimized.

Member

sloria commented Dec 9, 2015

Thank you. Made a hotfix release (2.4.2).

@alexmorken alexmorken deleted the alexmorken:bugfix/error-handling-nested-many-schema-validator branch Dec 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment