Pass through user ValidationError kwargs #418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. This is a known issue. This issue is the likely the cause of marshmallow-code/webargs#85. I'll test this out when I get some time. |
| @@ -181,6 +183,7 @@ def run_validator(self, validator_func, output, | |||
| raise ValidationError(self.default_schema_validation_error) | |||
| except ValidationError as err: | |||
| errors = self.get_errors(index=index) | |||
| self.kwargs = err.kwargs | |||
There was a problem hiding this comment.
Since multiple ValidationErrors may be raised during validation, it might make sense to do self.kwargs.update(err.kwargs).
There was a problem hiding this comment.
Good point, I've updated the pull request.
russelldavies
force-pushed
the
exception_kwargs
branch
from
0f0df21
to
187b1ab
Compare
|
A more complete implementation of this is in #428. |
|
@russelldavies any thoughts on #996? |
|
@lafrech I haven't used this library for a long time now so can't comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I noticed that in
ValidationErrorthere is akwargsdictionary, which seems to be for user arguments. I thought I'd use it to add astatus_codekwarg so that when I catch the exception in my code I could add a bit more semantic information to the response. However, because of how the schema loading works, it is discarded.This patch fixes this but I'm not sure it's clean enough to get merged. Perhaps a more extensive refactoring is required.